[FIX] util.remove_field: keep field info

When removing a field, we can now keep the tracking as 'field_id' is not
required anymore and tracking model holds a 'fields_info' column to keep
removed field information.

This globally matches the behavior implemented at `IrModelField.unlink()`
as done in odoo/odoo#124182 . Note that tracking sequence is lost as it is
not stored in DB (it is a field parameter available in registry) but it
seems like an acceptable trade-off.

Task-3345979

Part of odoo/upgrade#5239

Signed-off-by: Christophe Simonis (chs) <[email protected]>

Author: tde-banana-odoo

src/util/fields.py

@@ -174,6 +174,34 @@ def adapter(leaf, is_or, negated):
             [model, fieldname],
         )
 
+    # update tracking values
+    if column_exists(cr, "mail_tracking_value", "field_info"):
+        cr.execute(
+            """
+                SELECT id, field_description, name, ttype
+                  FROM ir_model_fields
+                 WHERE model=%s
+                   AND name=%s
+            """,
+            (model, fieldname),
+        )
+        if cr.rowcount:
+            (field_id, field_desc_w_translation, name, ttype) = cr.fetchone()
+            field_desc = field_desc_w_translation.get("en_US", next(iter(field_desc_w_translation.values())))
+            fields_info = {
+                "desc": field_desc,
+                "name": name,
+                "type": ttype,
+            }
+            cr.execute(
+                """
+                UPDATE mail_tracking_value
+                   SET field_info = %s
+                 WHERE field_id = %s
+                """,
+                (psycopg2.extras.Json(fields_info), field_id),
+            )
+
     # remove this field from dependencies of other fields
     if column_exists(cr, "ir_model_fields", "depends"):
         cr.execute(