[IMP] orm: iter_browse accept generator or query as ids or values #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
cawo-odoo
force-pushed
the
master-imp_iter_browse_save_memory-cawo
branch
2 times, most recently
from
01d0fba to
16a2e55
Compare
Contributor
|
upgradeci retry with always only account |
cawo-odoo
force-pushed
the
master-imp_iter_browse_save_memory-cawo
branch
2 times, most recently
from
d3e1776 to
ebf911e
Compare
Contributor
Author
|
rebased on #355 to also make use of |
cawo-odoo
force-pushed
the
master-imp_iter_browse_save_memory-cawo
branch
5 times, most recently
from
cdfe851 to
161bdfb
Compare
This is mainly the code that has been recently added to `orm.recompute_fields`, here we're making it re-usasble.
This code in recompute_fields has been made re-usable in a new util pg.query_ids. Use that.
```
Traceback (most recent call last):
[...]
File "/tmp/tmpipxrg2eq/migrations/util/models.py", line 563, in merge_model
remove_model(cr, source, drop_table=drop_table, ignore_m2m=ignore_m2m)
File "/tmp/tmpipxrg2eq/migrations/util/models.py", line 138, in remove_model
it = chunks([id for (id,) in cr.fetchall()], chunk_size, fmt=tuple)
MemoryError
```
Some IR tables can be large. Avoid `cr.fetchall()` when getting ids by use of
pg.query_ids()
This allows the caller to be memory efficient on huge numbers of ids, allowing for even more millions of records to be browsed.
Done to be able to create millions of records memory-efficiently.
cawo-odoo
force-pushed
the
master-imp_iter_browse_save_memory-cawo
branch
from
161bdfb to
ad0d9e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IMP] orm: iter_browse accept generator or query as ids
This allows the caller to be memory efficient on huge numbers of ids, allowing for even more millions of records to be browsed.
[IMP] orm: iter_browse.create() accept generator or query as values
Done to be able to create millions of records memory-efficiently.