Skip to content

Add a warding processor #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
micaelbergeron wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Add a warding processor #3

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7e49bb5
Add a warding processor
Sep 14, 2016
2dab48f
Update postbuild.sh
howardchung Sep 15, 2016
c7be138
reword annotions and fix code style
Sep 15, 2016
74474b1
Update .travis.yml
howardchung Sep 15, 2016
a72fcaa
extract player_slot for cosmetics
howardchung Sep 18, 2016
47530fb
Merge branch 'master' of github.com:yasp-dota/parser
howardchung Sep 18, 2016
510d6f2
add some owner hero entity data
howardchung Sep 19, 2016
063e10c
update rebuild script
howardchung Sep 20, 2016
39c1428
Add a warding processor
Sep 14, 2016
cb76494
reword annotions and fix code style
Sep 15, 2016
966684a
Merge branch 'master' of github.com:micaelbergeron/parser
Oct 6, 2016
4141fad
correct an edge case on same-tick events
Oct 24, 2016
55a0a45
update the Dockerfile to expose the parser's port
Oct 24, 2016
57fa27b
remove the indirection map (was not used)
Oct 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,6 @@ WORKDIR /usr/src/parser
ADD . /usr/src/parser
RUN mvn -q -f /usr/src/parser/pom.xml clean install -U

EXPOSE 5600
Copy link
Member

@howardchung howardchung Oct 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did this work before? port option passed via Docker command line?

Copy link
Author

@micaelbergeron micaelbergeron Oct 25, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because the new docker-compose is using named services to access the other services instead of going through the host networking. It is good practice to EXPOSE listening ports on your docker components, it makes it easy to expose the service to other components.

As you can see in docker-compose.yml

    environment:
      PARSER_HOST: http://odota-parser:5600
      POSTGRES_URL: postgresql://postgres:postgres@odota-postgres/yasp
      POSTGRES_TEST_URL: postgresql://postgres:postgres@odota-postgres/yasp_test
      READONLY_POSTGRES_URL: postgresql://readonly:readonly@odota-postgres/yasp
      REDIS_URL: redis://odota-redis:6379/0
      REDIS_TEST_URL: redis://odota-redis:6379/1
      CASSANDRA_URL: cassandra://odota-cassandra/yasp
      CASSANDRA_TEST_URL: cassandra://odota-cassandra/yasp_test

I think docker-compose automatically expose the image EXPOSED ports.


CMD ["java", "-jar", "-Xmx256m", "/usr/src/parser/target/stats-0.1.0.jar", "5600"]
Copy link
Member

@howardchung howardchung Oct 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will you need to update this for the jar name?

Copy link
Author

@micaelbergeron micaelbergeron Oct 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I've changed the pom.xml to output the same filename as before.