Skip to content

Fix name of profile in field efficiency#118

Draft
MaGering wants to merge 6 commits intodevfrom
fix/efficiency_profile
Draft

Fix name of profile in field efficiency#118
MaGering wants to merge 6 commits intodevfrom
fix/efficiency_profile

Conversation

@MaGering
Copy link
Contributor

@MaGering MaGering commented Aug 1, 2023

Resolves #117

With this PR it is possible to have multiple foreign efficiency profiles.

Open ToDo:

  • Docs need to be updated

@MaGering MaGering added the bug Something isn't working label Aug 1, 2023
@MaGering MaGering self-assigned this Aug 1, 2023
@MaGering MaGering force-pushed the fix/efficiency_profile branch from 6f3ba56 to 81343b1 Compare August 1, 2023 17:21
@MaGering MaGering requested a review from iuljan August 1, 2023 17:22
@MaGering MaGering force-pushed the fix/efficiency_profile branch from 81343b1 to a32dde5 Compare August 2, 2023 09:17
@iuljan
Copy link
Collaborator

iuljan commented Aug 2, 2023

@MaGering some test fail locally due to your changes. I dont understand why they dont fail with the CI...

@MaGering
Copy link
Contributor Author

MaGering commented Aug 3, 2023

@MaGering some test fail locally due to your changes. I dont understand why they dont fail with the CI...

Did you install tabular with pip install oemof.tabular or pip install -e .? Because only with the latter the tests work locally for me.

@iuljan iuljan marked this pull request as draft August 4, 2023 13:29
@iuljan
Copy link
Collaborator

iuljan commented Aug 4, 2023

Let's put this on hold until we figured out if this is possible to fix on the oemof.flex side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only one profile for efficiency possible

2 participants

Comments