Conversation
Tsam is currently only available for multi-period.
henhuy
left a comment
henhuy
left a comment
There was a problem hiding this comment.
Structure in datapackage looks good to me!
But I have failing tests on my side:
- test_example_datapackage_readability
- test_scripting_examples
- test_examples_datapackages_scripts_infer
Do the tests also fail on your side?
|
Why did yo mark it as "breaking change"? IMO, this should not interfere with older tabular versions?! |
I guess, I slipped...
yes, I still have to adjust the component timeseries. |
TSA timesteps are now disaggregated internally from periods in oemof.solph
There was a problem hiding this comment.
When looking into TSAm parameters of example datapackage "dispatch_multi_period_tsam", I found that third period has an invalid order (containing 3 different typical periods, which would sum up to 6 timesteps in third period, but only 4 are given) which must normally lead to an error when building energysystem. Thus, I wondered why no error is thrown - on my side, this was due to wrong oemof.solph version (one which does not include TSAM parameters - so that they are neglected when building ES ergo no error is thrown). Updating oemof.solph, pointing to branch feature/integrate_tsam unfortunately lead to dependency issues as oemof.networkand oemof.tools versions are not correctly pinned in oemof.solph. After manually fixing those versions, I finally could see the error resulting from invalid TSAM parameters - but unfurtunately, now I can see multiple other errors in other tests (regarding wrong LP-files and stuff).
I think, in order to finalize this PR, we should do following:
- fix dependencies in
oemof.solph - fix TSAM parameters in example
- look into errors from other tests and check if they belong into this PR or have to be adapted in other PR (as bringing
oemof.tabularin line with latestoemof.solphversion)
…emof-tabular into features/add-tsam-to-datapackage
|
Regarding changed LP files please see #155 |
…' into features/add-tsam-to-datapackage # Conflicts: # setup.py
# Conflicts: # setup.py # src/oemof/tabular/datapackage/reading.py
|
This will only be merged after tsam-branch in |
This leads to an error when inferring metadata, as new datapackage adds a counter to second "tech" column, resulting in "tech2"
3 participants
Description
Tsam option is now available for tabular reading module, but only for multi-period approach.
Parameters need to be provided by two separate
csvs.tsa_paramters (period, timesteps_per_period, order)
add example
adjust timeseries data of example
Fixes #138
Type of change
Please tick or delete options that are not relevant.
Checklist:
Please tick or delete options that are not relevant.
pre-commithooks