Skip to content

Add wrapper to enhance info on failed facade creation#145

Open
iuljan wants to merge 4 commits intodevfrom
features/reading-error-enhancer
Open

Add wrapper to enhance info on failed facade creation#145
iuljan wants to merge 4 commits intodevfrom
features/reading-error-enhancer

Conversation

@iuljan
Copy link
Collaborator

@iuljan iuljan commented Nov 30, 2023

Description

This wrapper catches errors while creating the facade in the reading module. This way, at least some information on which facade failed and where to look in the data are supplied.

Type of change

Please tick or delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

Please tick or delete options that are not relevant.

  • New and adjusted code is formatted using the pre-commit hooks
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added new features/fixes to the CHANGELOG

@iuljan iuljan self-assigned this Dec 4, 2023
@iuljan iuljan added the enhancement New feature or request label Dec 4, 2023
@iuljan iuljan requested a review from henhuy December 5, 2023 15:14
@iuljan
Copy link
Collaborator Author

iuljan commented Dec 15, 2023

@henhuy The only way to test this is by providing a false datapackage. I already had this before in #134. Do you think it makes sense to add one to the tests?

@henhuy
Copy link
Collaborator

henhuy commented Dec 15, 2023

@henhuy The only way to test this is by providing a false datapackage. I already had this before in #134. Do you think it makes sense to add one to the tests?

I think this would be helpful indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments