Improve automatic generation of datapackage.json file#191
Draft
Bachibouzouk wants to merge 13 commits intodevfrom
Draft
Improve automatic generation of datapackage.json file#191Bachibouzouk wants to merge 13 commits intodevfrom
Bachibouzouk wants to merge 13 commits intodevfrom
Conversation
Before only ForeignKeys to the resource "bus" were deemed valid, which was arbitraty as the fk one wanted to rule out where explicitely the fk to any resource within the "sequences" folder
Otherwise the argument "name" is renamed into "label", which we want to avoid in the general case
Now the automatic inferrence of the foreign keys makes this code obsolete. "bus.csv" is a special resource which must be there. All fields from all resources which are string will be compared to the column "name" of the bus resource and if there is a match, a foreign key will be established. For profiles it it the header of all the resources saved under "sequences" folder which will be searched through
Before only the resource "bus" was search for potential foreign keys target, now one can provide a list of resources which are potential foreign keys target. By default "bus" is always present.
Bachibouzouk
force-pushed
the
fix/datapackage
branch
from
16d963f to
c79663a
Compare
This was the case of project.csv which was neither a part of elements nor of sequences
Now that Node are fractal, there is no need to add the subnodes to the energysystem, they are added within Network already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an attempt to be able to build and model of an energy system and run it with the https://github.com/oemof/oemof-solph/releases/tag/v0.6.1 release of oemof
Our usecase is based on oemof/oemof-eesyplan#5
Fixes # (issue)
Type of change
Checklist:
Please tick or delete options that are not relevant.
pre-commithooks