Skip to content

Implement an IncompressibleFluidWrapper class #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fwitte merged 24 commits into from
Jan 13, 2026
Merged

Implement an IncompressibleFluidWrapper class #878

fwitte merged 24 commits into from
Jan 13, 2026

Conversation

@fwitte
Copy link
Member

@fwitte fwitte commented Jan 5, 2026 •
edited
Loading

Resolves #876

  • Implement unit tests for the changes
  • Update the documentation
  • For a new feature: Implement an example and a system test
  • Update the changelog at docs/whats_new/*

fwitte added 24 commits January 4, 2026 10:04
@fwitte
Prepare the possibility to specify wrapper kwrags in the form of a dict
408ef53
@fwitte
Implement a simple test method to check if kwargs can be injected via…
1a3dc9a 
… Connection API
@fwitte
Merge branch 'dev' into feature/#876-incompressiblefluidwrapper
3bc57af
@fwitte
Also propagate the fluid wrapper kwargs
edfbb4f
@fwitte
Implement a simple way for Arrhenius viscosity model and linear densi…
ab5c920 
…ty and heat capacity
@fwitte
Update changelog
7afb0d1
@fwitte
Add testing for the newly implemented wrapper
77363eb
@fwitte
Run isort
f2daf98
@fwitte
Change minimum number of datapoints
58c3ad8
@fwitte
Fix heat capacity data
76d7242
@fwitte
Write some docs
9d1caff
@fwitte
Insert missing newlines
3e6910b
@fwitte
Clean up a bit
bac5921
@fwitte
Add entropy
2c41acb
@fwitte
Fix isentropic calculation by only considering pressure change and as…
793e349 
…suming constant temperature
@fwitte
Add a fitting report and change viscosity to higher order polynomial
8041ad3
@fwitte
Make error tolerance more strict
a3bcc3b
@fwitte
Add a legend and proper axis labels for the plots
fee7e3c
@fwitte
Add a conductivity fitting test
e3f38d0
@fwitte
Also test conductivity high level access
ee1b999
@fwitte
UPdate docs
c53d9f0
@fwitte
Update fitting description for viscosity and add a cautionary note
def2b27
@fwitte
Add some class docstring
0d63967
@fwitte
Add to FAQ
953570f
@fwitte fwitte merged commit 6b6fa5a into dev Jan 13, 2026
11 checks passed
@fwitte fwitte deleted the feature/#876-incompressiblefluidwrapper branch January 19, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement data fitting for incompressible fluids

2 participants

@fwitte