[WIP] Upgrade to EmberCLI 3.5.1 by allthesignals · Pull Request #126 · offirgolan/ember-time-machine

allthesignals · 2018-11-27T18:36:40Z

This PR upgrades ember-cli to 3.5.1. It also runs codemods for es6 modules. Largely, it removes bower dependencies for addon consumers but not for development mode.

In development mode, some tests still fail for reasons having to do with the test suite itself. I am blocked on understanding why those tests fail - any advice will help!

offirgolan · 2018-11-27T18:57:24Z

Thanks for taking this up @allthesignals! Let me know when the PR is ready and I'll review/merge/release 😄

offirgolan · 2018-11-27T18:59:54Z

In development mode, some tests still fail for reasons having to do with the test suite itself. I am blocked on understanding why those tests fail - any advice will help!

I'm unsure as well. I'll have to take a look when I have some time.

allthesignals · 2018-11-27T19:14:09Z

Thanks for taking this up @allthesignals! Let me know when the PR is ready and I'll review/merge/release 😄

My pleasure!

In development mode, some tests still fail for reasons having to do with the test suite itself. I am blocked on understanding why those tests fail - any advice will help!

I'm unsure as well. I'll have to take a look when I have some time.

Main errors are:

Uncaught Error: Ember Data Request GET /api/users/1 returned a 404
You cannot use the same root element (DIV) multiple times in an Ember.Application

Here's the failing test logs:

Details

not ok 1 Chrome 70.0 - [undefined ms] - Global error: Uncaught Error: Ember Data Request GET /api/users/1 returned a 404
Payload (Empty Content-Type)
Not Found at http://localhost:7357/assets/vendor.js, line 58872
    ---
        Log: |
            { type: 'error',
              text: '\'Error while processing route: index\' \'Ember Data Request GET /api/users/1 returned a 404\\nPayload (Empty Content-Type)\\nNot Found\' \'Error: Ember Data Request GET /api/users/1 returned a 404\\nPayload (Empty Content-Type)\\nNot Found\\n    at ErrorClass.EmberError (http://localhost:7357/assets/vendor.js:24017:31)\\n    at ErrorClass.AdapterError (http://localhost:7357/assets/vendor.js:150606:17)\\n    at new ErrorClass (http://localhost:7357/assets/vendor.js:150624:24)\\n    at Class.handleResponse (http://localhost:7357/assets/vendor.js:162888:18)\\n    at ajaxError (http://localhost:7357/assets/vendor.js:163168:25)\\n    at ajaxErrorHandler (http://localhost:7357/assets/vendor.js:163204:12)\\n    at Class.hash.error (http://localhost:7357/assets/vendor.js:162963:23)\\n    at fire (http://localhost:7357/assets/vendor.js:13991:31)\\n    at Object.fireWith [as rejectWith] (http://localhost:7357/assets/vendor.js:14121:7)\\n    at done (http://localhost:7357/assets/vendor.js:20030:14)\'\n' }
            { type: 'error',
              testContext: {},
              text: 'Uncaught Error: Ember Data Request GET /api/users/1 returned a 404\nPayload (Empty Content-Type)\nNot Found at http://localhost:7357/assets/vendor.js, line 58872\n' }
    ...same
not ok 105 Chrome 70.0 - [124 ms] - Unit | Utility | object: getObject
    ---
        actual: >
            null
        stack: >
            Error: Assertion Failed: You cannot use the same root element (DIV) multiple times in an Ember.Application
                at new EmberError (http://localhost:7357/assets/vendor.js:24017:31)
                at assert (http://localhost:7357/assets/vendor.js:22881:23)
                at Class.setup (http://localhost:7357/assets/vendor.js:65637:81)
                at Class.setupEventDispatcher (http://localhost:7357/assets/vendor.js:21625:18)
                at Class._bootSync (http://localhost:7357/assets/vendor.js:21580:14)
                at http://localhost:7357/assets/vendor.js:23845:30
                at initializePromise (http://localhost:7357/assets/vendor.js:70104:7)
                at new Promise (http://localhost:7357/assets/vendor.js:70584:35)
                at Class.boot (http://localhost:7357/assets/vendor.js:23844:27)
                at application.boot.then.app (http://localhost:7357/assets/tests.js:214:65)
        message: >
            Promise rejected before "getObject": Assertion Failed: You cannot use the same root element (DIV) multiple times in an Ember.Application
        negative: >
            false
        Log: |
    ...
not ok 106 Chrome 70.0 - [60 ms] - Unit | Utility | object: getObject - ember array
    ---
        actual: >
            null
        stack: >
            Error: Assertion Failed: You cannot use the same root element (DIV) multiple times in an Ember.Application
                at new EmberError (http://localhost:7357/assets/vendor.js:24017:31)
                at assert (http://localhost:7357/assets/vendor.js:22881:23)
                at Class.setup (http://localhost:7357/assets/vendor.js:65637:81)
                at Class.setupEventDispatcher (http://localhost:7357/assets/vendor.js:21625:18)
                at Class._bootSync (http://localhost:7357/assets/vendor.js:21580:14)
                at http://localhost:7357/assets/vendor.js:23845:30
                at initializePromise (http://localhost:7357/assets/vendor.js:70104:7)
                at new Promise (http://localhost:7357/assets/vendor.js:70584:35)
                at Class.boot (http://localhost:7357/assets/vendor.js:23844:27)
                at application.boot.then.app (http://localhost:7357/assets/tests.js:214:65)
        message: >
            Promise rejected before "getObject - ember array": Assertion Failed: You cannot use the same root element (DIV) multiple times in an Ember.Application
        negative: >
            false
        Log: |
    ...
not ok 107 Chrome 70.0 - [42 ms] - Unit | Utility | object: getObject - ember array proxy
    ---
        actual: >
            null
        stack: >
            Error: Assertion Failed: You cannot use the same root element (DIV) multiple times in an Ember.Application
                at new EmberError (http://localhost:7357/assets/vendor.js:24017:31)
                at assert (http://localhost:7357/assets/vendor.js:22881:23)
                at Class.setup (http://localhost:7357/assets/vendor.js:65637:81)
                at Class.setupEventDispatcher (http://localhost:7357/assets/vendor.js:21625:18)
                at Class._bootSync (http://localhost:7357/assets/vendor.js:21580:14)
                at http://localhost:7357/assets/vendor.js:23845:30
                at initializePromise (http://localhost:7357/assets/vendor.js:70104:7)
                at new Promise (http://localhost:7357/assets/vendor.js:70584:35)
                at Class.boot (http://localhost:7357/assets/vendor.js:23844:27)
                at application.boot.then.app (http://localhost:7357/assets/tests.js:214:65)
        message: >
            Promise rejected before "getObject - ember array proxy": Assertion Failed: You cannot use the same root element (DIV) multiple times in an Ember.Application
        negative: >
            false
        Log: |
    ...
not ok 108 Chrome 70.0 - [123 ms] - Unit | Utility | object: setObject
    ---
        actual: >
            null
        stack: >
            Error: Assertion Failed: You cannot use the same root element (DIV) multiple times in an Ember.Application
                at new EmberError (http://localhost:7357/assets/vendor.js:24017:31)
                at assert (http://localhost:7357/assets/vendor.js:22881:23)
                at Class.setup (http://localhost:7357/assets/vendor.js:65637:81)
                at Class.setupEventDispatcher (http://localhost:7357/assets/vendor.js:21625:18)
                at Class._bootSync (http://localhost:7357/assets/vendor.js:21580:14)
                at http://localhost:7357/assets/vendor.js:23845:30
                at initializePromise (http://localhost:7357/assets/vendor.js:70104:7)
                at new Promise (http://localhost:7357/assets/vendor.js:70584:35)
                at Class.boot (http://localhost:7357/assets/vendor.js:23844:27)
                at application.boot.then.app (http://localhost:7357/assets/tests.js:214:65)
        message: >
            Promise rejected before "setObject": Assertion Failed: You cannot use the same root element (DIV) multiple times in an Ember.Application
        negative: >
            false
        Log: |
    ...
not ok 109 Chrome 70.0 - [51 ms] - Unit | Utility | record: pathInGlobs - simple
    ---
        actual: >
            null
        stack: >
            Error: Assertion Failed: You cannot use the same root element (DIV) multiple times in an Ember.Application
                at new EmberError (http://localhost:7357/assets/vendor.js:24017:31)
                at assert (http://localhost:7357/assets/vendor.js:22881:23)
                at Class.setup (http://localhost:7357/assets/vendor.js:65637:81)
                at Class.setupEventDispatcher (http://localhost:7357/assets/vendor.js:21625:18)
                at Class._bootSync (http://localhost:7357/assets/vendor.js:21580:14)
                at http://localhost:7357/assets/vendor.js:23845:30
                at initializePromise (http://localhost:7357/assets/vendor.js:70104:7)
                at new Promise (http://localhost:7357/assets/vendor.js:70584:35)
                at Class.boot (http://localhost:7357/assets/vendor.js:23844:27)
                at application.boot.then.app (http://localhost:7357/assets/tests.js:214:65)
        message: >
            Promise rejected before "pathInGlobs - simple": Assertion Failed: You cannot use the same root element (DIV) multiple times in an Ember.Application
        negative: >
            false
        Log: |
    ...
not ok 110 Chrome 70.0 - [50 ms] - Unit | Utility | record: pathInGlobs - each
    ---
        actual: >
            null
        stack: >
            Error: Assertion Failed: You cannot use the same root element (DIV) multiple times in an Ember.Application
                at new EmberError (http://localhost:7357/assets/vendor.js:24017:31)
                at assert (http://localhost:7357/assets/vendor.js:22881:23)
                at Class.setup (http://localhost:7357/assets/vendor.js:65637:81)
                at Class.setupEventDispatcher (http://localhost:7357/assets/vendor.js:21625:18)
                at Class._bootSync (http://localhost:7357/assets/vendor.js:21580:14)
                at http://localhost:7357/assets/vendor.js:23845:30
                at initializePromise (http://localhost:7357/assets/vendor.js:70104:7)
                at new Promise (http://localhost:7357/assets/vendor.js:70584:35)
                at Class.boot (http://localhost:7357/assets/vendor.js:23844:27)
                at application.boot.then.app (http://localhost:7357/assets/tests.js:214:65)
        message: >
            Promise rejected before "pathInGlobs - each": Assertion Failed: You cannot use the same root element (DIV) multiple times in an Ember.Application
        negative: >
            false
        Log: |
    ...
not ok 111 Chrome 70.0 - [40 ms] - Unit | Utility | record: pathInGlobs - wildcards
    ---
        actual: >
            null
        stack: >
            Error: Assertion Failed: You cannot use the same root element (DIV) multiple times in an Ember.Application
                at new EmberError (http://localhost:7357/assets/vendor.js:24017:31)
                at assert (http://localhost:7357/assets/vendor.js:22881:23)
                at Class.setup (http://localhost:7357/assets/vendor.js:65637:81)
                at Class.setupEventDispatcher (http://localhost:7357/assets/vendor.js:21625:18)
                at Class._bootSync (http://localhost:7357/assets/vendor.js:21580:14)
                at http://localhost:7357/assets/vendor.js:23845:30
                at initializePromise (http://localhost:7357/assets/vendor.js:70104:7)
                at new Promise (http://localhost:7357/assets/vendor.js:70584:35)
                at Class.boot (http://localhost:7357/assets/vendor.js:23844:27)
                at application.boot.then.app (http://localhost:7357/assets/tests.js:214:65)
        message: >
            Promise rejected before "pathInGlobs - wildcards": Assertion Failed: You cannot use the same root element (DIV) multiple times in an Ember.Application
        negative: >
            false
        Log: |
    ...
not ok 113 Chrome 70.0 - [1 ms] - Unit | Proxy | object: global failure
    ---
        actual: >
            null
        stack: >
            Error: Ember Data Request GET /api/users/1 returned a 404
            Payload (Empty Content-Type)
            Not Found
                at ErrorClass.EmberError (http://localhost:7357/assets/vendor.js:24017:31)
                at ErrorClass.AdapterError (http://localhost:7357/assets/vendor.js:150606:17)
                at new ErrorClass (http://localhost:7357/assets/vendor.js:150624:24)
                at Class.handleResponse (http://localhost:7357/assets/vendor.js:162888:18)
                at ajaxError (http://localhost:7357/assets/vendor.js:163168:25)
                at ajaxErrorHandler (http://localhost:7357/assets/vendor.js:163204:12)
                at Class.hash.error (http://localhost:7357/assets/vendor.js:162963:23)
                at fire (http://localhost:7357/assets/vendor.js:13991:31)
                at Object.fireWith [as rejectWith] (http://localhost:7357/assets/vendor.js:14121:7)
                at done (http://localhost:7357/assets/vendor.js:20030:14)
        message: >
            Uncaught Error: Ember Data Request GET /api/users/1 returned a 404
            Payload (Empty Content-Type)
            Not Found
        negative: >
            false
        Log: |
    ...

1..113
# tests 113
# pass  104
# skip  0
# fail  9

allthesignals added 4 commits November 27, 2018 11:43

Upgrade Ember CLI to 3.5.1

77da0d7

Upgrade/add missing deps

6957817

Upgrade packages; run es6 module codemod

b944a4f

Update to running test suite; Linter fixes

4f52af2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Upgrade to EmberCLI 3.5.1#126

[WIP] Upgrade to EmberCLI 3.5.1#126
allthesignals wants to merge 4 commits intooffirgolan:masterfrom
allthesignals:master

allthesignals commented Nov 27, 2018

Uh oh!

offirgolan commented Nov 27, 2018

Uh oh!

offirgolan commented Nov 27, 2018

Uh oh!

allthesignals commented Nov 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

allthesignals commented Nov 27, 2018

Uh oh!

offirgolan commented Nov 27, 2018

Uh oh!

offirgolan commented Nov 27, 2018

Uh oh!

allthesignals commented Nov 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants