performance/multi-node: use fi_inject_write.#59
Open
e-harvey wants to merge 3 commits intoofi-cray:masterfrom
Open
performance/multi-node: use fi_inject_write.#59e-harvey wants to merge 3 commits intoofi-cray:masterfrom
e-harvey wants to merge 3 commits intoofi-cray:masterfrom
Conversation
Member
|
motivation for this PR? Why is this being done? |
Contributor
Author
Mainly because @hppritcha asked me to. Also, to compare the performance of fi_write to fi_write_inject. |
Member
You need to amend your commit and PR descriptions to reflect that. |
- Use fi_write_inject until the inject threshold is exceeded. - This is to compare the performance of fi_inject_write to fi_write. Signed-off-by: Evan Harvey <eharvey@lanl.gov>
306256e to
bdc4d8a
Compare
Contributor
|
This PR should change to add the option to using fi_write_inject. The default behavior should be as it is now. |
- Enable fi_inject_write by using the -j flag. Signed-off-by: Evan Harvey <eharvey@lanl.gov>
Contributor
|
Why |
Contributor
Author
|
Contributor
|
Oh yeah. I'd use |
Contributor
Author
Did you mean |
Signed-off-by: Evan Harvey <eharvey@lanl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the changes introduced in this PR we get:
at https://github.com/ofi-cray/libfabric-cray/tree/6cdc8c283feecc2b3b881666598edcf96dd56d5e:
and at https://github.com/ofi-cray/libfabric-cray/tree/2b63528292d4ead86c120f134edfc6ccb25f8369:
Signed-off-by: Evan Harvey eharvey@lanl.gov