Open
Conversation
Fix compilation of verbs provider with ofed 3.12-1
Move internal headers to include/ , then include them with quotes (copying libfabric style). Internal headers should contain sybols that are not exported up or down, and only used by kfi kernel module. Removed ifdef't strdup,ntholl, then removed empty kfi.h. Signed-off-by: pmmccorm <patrick.m.mccormick@intel.com>
This way each provider does not have to compile in the functions into their modules, they instead just link to kfi core module. Signed-off-by: pmmccorm <patrick.m.mccormick@intel.com>
soniczhao
force-pushed
the
master
branch
3 times, most recently
from
569f04a to
01bf555
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move internal headers to include, make enosys part of kfi.