prov/cxi: avoid fat lock for progress counter #11775
Open
+8
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just use an atomic counter, the only thing this lock protects is a single uint32. Signed-off-by: Nicholas Sielicki <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR optimizes the progress counter implementation by replacing a lock-protected integer field with atomic operations. The change eliminates unnecessary lock overhead for a single uint32_t counter that tracks the number of operations needing progress.
Key changes:
- Replaced
progress_count_lockspinlock with lock-free atomic operations - Converted
progress_countfrominttoofi_atomic32_ttype - Updated all access functions to use atomic increment, decrement, and get operations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| prov/cxi/include/cxip.h | Replaced lock-protected counter field with atomic type and updated inline helper functions to use atomic operations |
| prov/cxi/src/cxip_cntr.c | Removed lock initialization/destruction, added atomic counter initialization, and fixed spelling typo in comment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
j-xiong
approved these changes
Jan 5, 2026
Contributor
j-xiong
left a comment
j-xiong
left a comment
There was a problem hiding this comment.
LGTM, I'll let provider owner(s) to double check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just use an atomic counter, the only thing this lock protects is a single uint32.