prov/cxi: evtq: fix logic in saturation check #11776
Open
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if (sec < prev_sec) but (ns > prev_ns), eg: wraparound on seconds occurs, this erroneously triggers. Signed-off-by: Nicholas Sielicki <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the event queue saturation check logic where timestamps are compared to detect hardware writebacks. The original code incorrectly used an OR condition that would trigger when nanoseconds increased regardless of whether seconds decreased, causing false positives when timestamp components wrapped around.
Key Changes:
- Fixed timestamp comparison logic to properly handle two-part timestamps (seconds and nanoseconds)
- Changed from
(sec > prev_sec || ns > prev_ns)to(sec > prev_sec || (sec == prev_sec && ns > prev_ns))
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jswaro
reviewed
Jan 5, 2026
Contributor
jswaro
left a comment
jswaro
left a comment
There was a problem hiding this comment.
Let's discuss this internally. I don't think this is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if (sec < prev_sec) but (ns > prev_ns), eg: wraparound on seconds occurs, this erroneously triggers.