Fix efa_mr_reg_impl/fa_mr_dereg_impl race condition #11786
+31
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijin-aws
reviewed
Jan 5, 2026
include/ofi_atom.h
Outdated
| } \ | ||
| static inline \ | ||
| size_t ofi_atomic_inc_counter(ofi_atomic_counter *atomic) \ | ||
| { \ |
Contributor
There was a problem hiding this comment.
Can it be merged with ofi_atomic_inc/add/set/dec functions?
Contributor
Author
There was a problem hiding this comment.
I think that can be done, but not so trivial. The way OFI_ATOMIC_DEFINE macro is implemented it does not have options for unsigned integer and memory model (following Windows model I guess). Therefore the macro definition is going to become extremely complex.
Contributor
Author
There was a problem hiding this comment.
I'm excluding the new define from this PR. Going to cut a new PR with better macros.
For the time being we can use signed integer ofi_atomic64_t.
alekswn
force-pushed
the
fix-efa_mr_reg_impl-race
branch
4 times, most recently
from
a775e45 to
1643733
Compare
Convert ibv_mr_reg_ct and ibv_mr_reg_sz from plain size_t to ofi_atomic64_t to ensure thread-safe access in multi-threaded environments. This prevents race conditions when multiple threads register/deregister memory regions concurrently. Changes: - Use ofi_atomic_add64()/ofi_atomic_inc64() for MR registration - Use ofi_atomic_sub64()/ofi_atomic_dec64() for deregistration - Maintain existing logging functionality with atomic-safe reads Signed-off-by: Alexey Novikov <[email protected]>
alekswn
force-pushed
the
fix-efa_mr_reg_impl-race
branch
from
1643733 to
5e9ab42
Compare
shijin-aws
approved these changes
Jan 7, 2026
Contributor
Author
|
bot:aws:retest |
Contributor
Author
|
bot:aws:retest |
1 similar comment
Contributor
Author
|
bot:aws:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ibv_mr_reg_ctandibv_mr_reg_sztoofi_atomic64