Skip to content

Comments

prov/hook: add include of prov/hook/perf/include to ofi_hook_profile if configured as DSO #11833

Open
philippfriese wants to merge 1 commit intoofiwg:mainfrom
philippfriese:ofi_hook_profile_dl
Open

prov/hook: add include of prov/hook/perf/include to ofi_hook_profile if configured as DSO #11833
philippfriese wants to merge 1 commit intoofiwg:mainfrom
philippfriese:ofi_hook_profile_dl

Conversation

@philippfriese
Copy link
Contributor

If the ofi_hook_profile provider is configured as a loadable library, then the file hook_perf.h will not be found during compilation:

$ ./configure --enable-profile=dl
[...]
***
*** Built-in providers:	lnx dmabuf_peer_mem hook_hmem hook_debug monitor trace perf sm2 shm rxd mrail rxm tcp udp sockets
*** DSO providers:	profile
***
$ make 
[...]
In file included from prov/hook/profile/src/hook_profile.c:36:
./prov/hook/include/hook_prov.h:14:10: fatal error: hook_perf.h: No such file or directory
   14 | #include "hook_perf.h"
      |          ^~~~~~~~~~~~~
compilation terminated.

This file is transitively included via hook_prov.h:14 in hook_profile.c:36. The #if HAVE_PERF check passes by default since ofi_hook_perf is built by default.

This PR adds the missing include of prov/hook/perf/include in case the ofi_hook_profile provider is configured as a DSO.

…ile is build as a loadable library

Signed-off-by: Philipp Friese <philipp.friese@cit.tum.de>
Copy link
Contributor

@j-xiong j-xiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants