prov/efa: Fix 0 byte send/read/write support#11890
Open
a-szegel wants to merge 10 commits intoofiwg:mainfrom
Open
prov/efa: Fix 0 byte send/read/write support#11890a-szegel wants to merge 10 commits intoofiwg:mainfrom
a-szegel wants to merge 10 commits intoofiwg:mainfrom
Conversation
Allocate and register a 4KB bounce buffer during EFA-direct domain initialization. This buffer will be used to support 0-byte inject operations which are required by libfabric semantics but not directly supported by the EFA device. The buffer is registered with FI_SEND | FI_RECV | FI_READ | FI_WRITE | FI_REMOTE_READ | FI_REMOTE_WRITE permissions to support all operation types. Memory registration uses efa_mr_internal_regv() to integrate with the provider's MR infrastructure. Signed-off-by: Seth Zegelstein <szegel@amazon.com>
Enable 0-byte RDMA read operations by using the pre-registered bounce buffer when total_len is 0. The implementation substitutes the bounce buffer's SGE and lkey into the first entry of the SGE list and sets iov_count to 1. This follows the libfabric requirement that providers must support 0-byte operations. Signed-off-by: Seth Zegelstein <szegel@amazon.com>
Enable 0-byte RDMA write operations by using the pre-registered bounce buffer when total_len is 0. The implementation follows the same pattern as 0-byte read: substitute the bounce buffer's SGE and lkey into the first entry of the SGE list and set iov_count to 1. This ensures compliance with libfabric semantics for 0-byte transfers. Signed-off-by: Seth Zegelstein <szegel@amazon.com>
Update assert in 0 byte read path to allow msg->iov_count to be equal to 0. Signed-off-by: Seth Zegelstein <szegel@amazon.com>
a-szegel
force-pushed
the
handle-0-byte-operations-in-efa-direct-rebased
branch
from
5ab67ea to
511d39e
Compare
Implement fi_inject_write[data] for 0-byte transfers using the pre-registered bounce buffer. The function only supports 0-byte operations and returns -FI_EOPNOTSUPP for non-zero lengths, as inline RDMA write is not yet supported at the device level. Update efa_rma_ops to use efa_rma_inject_write[data] instead of fi_no_rma_inject[data], enabling applications to perform 0-byte inject writes on EFA-direct. Signed-off-by: Seth Zegelstein <szegel@amazon.com>
Enable 0-byte message send operations by detecting len == 0 in efa_post_send and using the pre-registered bounce buffer as inline data. This centralizes the 0-byte handling logic in efa_post_send, allowing efa_ep_msg_inject to remain simple and consistent. The implementation sets up the bounce buffer as inline data with iov_count = 1 and use_inline = true, then continues with the normal send path. Signed-off-by: Seth Zegelstein <szegel@amazon.com>
Post the 0 byte RDMA Read with the pkt_entry's pre-registered bounce buffer, and MR to allow the user to pass in NULL/0 local buffer/descriptors. Signed-off-by: Seth Zegelstein <szegel@amazon.com>
Previous comment was incorrect because 0 byte send/tsend/read/write operations can have iov_count = 0. Signed-off-by: Seth Zegelstein <szegel@amazon.com>
local_iov_len does not have to equal remote_iov_len for 0 byte write. Signed-off-by: Seth Zegelstein <szegel@amazon.com>
Adds unit tests for 0 byte send/read/write for both efa-proto and efa-direct Signed-off-by: Seth Zegelstein <szegel@amazon.com>
a-szegel
force-pushed
the
handle-0-byte-operations-in-efa-direct-rebased
branch
from
511d39e to
a487a46
Compare
Contributor
Author
|
Looks like there are some real failures in CI that will need to be fixed before this PR can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns efa-proto and efa-direct to support doc updates in #11887.