Purge remnants of extensions v0 from Product#3548
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3548 +/- ##
===========================================
+ Coverage 76.23% 76.24% +0.01%
===========================================
Files 473 473
Lines 22117 22109 -8
Branches 2309 2309
===========================================
- Hits 16860 16857 -3
+ Misses 4740 4735 -5
Partials 517 517 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vigneshhari
left a comment
There was a problem hiding this comment.
This would have been overridden and worked correctly, but yeah we can clean it up.
|
Linting Changes Required |
Proposed Changes
validate_extensionsclass method and its@field_validatordecorator fromBaseProductSpec, which previously validated theextensionsfield using a JSON schema.Merge Checklist
/docsOnly PR's with test cases included and passing lint and test pipelines will be reviewed
@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins
Summary by CodeRabbit