Skip to content

fix: add facility_type validation to prevent 500 on invalid input #3554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rahwulkumar wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: add facility_type validation to prevent 500 on invalid input #3554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions care/emr/resources/facility/spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,15 @@ class FacilityCreateSpec(FacilityBaseSpec):
features: list[int]
print_templates: list[PrintTemplate] = []

@field_validator("facility_type")
@classmethod
def validate_facility_type(cls, v):
if v not in REVERSE_REVERSE_FACILITY_TYPES:
valid = ", ".join(sorted(REVERSE_REVERSE_FACILITY_TYPES.keys()))
err = f"Invalid facility type '{v}'. Valid options are: {valid}"
raise ValueError(err)
return v

@field_validator("name")
@classmethod
def validate_name_uniqueness(cls, v, info: ValidationInfo):
Expand Down