Skip to content

Conversation

@abhimanyurajeesh
Copy link
Contributor

@abhimanyurajeesh abhimanyurajeesh commented Jan 23, 2026

Proposed Changes

image

Summary by CodeRabbit

  • UI Updates
    • Updated button and label text throughout the billing interface, including payment reconciliation, invoice display, and account management pages
    • Revised action labels for payment recording, refund processing, and advance payment functions
    • Modified terminology in payment-related workflows and actions
    • Added new translation strings and updated billing terminology labels

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 23, 2026

Walkthrough

Updates to localization keys and UI labels across the billing module. Translation key "add_credit" was replaced with "advance_receipt", and button labels were changed from "record_credit_note" to "refund" in multiple billing components. No business logic was modified.

Changes

Cohort / File(s) Summary
Localization
public/locale/en.json
Replaced translation key add_credit with advance_receipt
Billing UI Label Updates
src/pages/Facility/billing/PaymentReconciliationSheet.tsx, src/pages/Facility/billing/account/AccountShow.tsx, src/pages/Facility/billing/invoice/InvoiceShow.tsx
Updated button labels and aria-labels: record_credit_noterefund, add_creditadvance_receipt, and creditadvance across billing interface components
🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is largely incomplete, containing only a screenshot with no textual explanation of changes, missing issue reference, bullet points, tags, and merge checklist items. Add issue number reference, list specific changes made (terminology replacements), include team tags, and complete the merge checklist with details on testing and documentation.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: updating terminology related to credit notes and receipts across multiple billing-related files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch manyu/fix/namings

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates billing terminology to use more appropriate financial terms, replacing "credit note" with "refund" and "add credit" with "advance/receipt" throughout the billing interface.

Changes:

  • Updated button labels in invoice and account views to use "refund" instead of "record_credit_note"
  • Changed "add_credit" to "advance_receipt" and "credit" to "advance" in account billing actions
  • Updated English locale file to reflect the new terminology

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/pages/Facility/billing/invoice/InvoiceShow.tsx Changed refund button text from "record_credit_note" to "refund"
src/pages/Facility/billing/account/AccountShow.tsx Updated multiple billing action labels: "add_credit" to "advance_receipt", "credit" to "advance", and "record_credit_note" to "refund"
src/pages/Facility/billing/PaymentReconciliationSheet.tsx Updated aria-label and button text for credit note actions to use "refund"
public/locale/en.json Removed "add_credit" translation key and added "advance_receipt" translation key

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/pages/Facility/billing/PaymentReconciliationSheet.tsx (1)

688-707: Inconsistent terminology: SheetTitle still uses "record_credit_note".

The submit button now correctly uses t("refund") for credit notes, but the SheetTitle at line 341 still uses t("record_credit_note"). This creates a UX inconsistency where the dialog title says one thing while the action button says another.

Consider updating line 341 for consistency:

Suggested fix
 <SheetTitle className="m-0">
-  {isCreditNote ? t("record_credit_note") : t("record_payment")}
+  {isCreditNote ? t("refund") : t("record_payment")}
 </SheetTitle>

@github-actions
Copy link

🎭 Playwright Test Results

Status: ❌ Failed
Test Shards: 3

Metric Count
Total Tests 171
✅ Passed 147
❌ Failed 24
⏭️ Skipped 0

📊 Detailed results are available in the playwright-final-report artifact.

Run: #5101

@github-actions github-actions bot added the Merge Conflict pull requests with merge conflict label Jan 25, 2026
@github-actions
Copy link

Conflicts have been detected against the base branch. Please merge the base branch into your branch.
cc: @abhimanyurajeesh

See: https://docs.ohc.network/docs/contributing#how-to-resolve-merge-conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge Conflict pull requests with merge conflict needs review needs testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants