-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: update terminology for credit notes and receipts in billing #15294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughUpdates to localization keys and UI labels across the billing module. Translation key "add_credit" was replaced with "advance_receipt", and button labels were changed from "record_credit_note" to "refund" in multiple billing components. No business logic was modified. Changes
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates billing terminology to use more appropriate financial terms, replacing "credit note" with "refund" and "add credit" with "advance/receipt" throughout the billing interface.
Changes:
- Updated button labels in invoice and account views to use "refund" instead of "record_credit_note"
- Changed "add_credit" to "advance_receipt" and "credit" to "advance" in account billing actions
- Updated English locale file to reflect the new terminology
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/pages/Facility/billing/invoice/InvoiceShow.tsx | Changed refund button text from "record_credit_note" to "refund" |
| src/pages/Facility/billing/account/AccountShow.tsx | Updated multiple billing action labels: "add_credit" to "advance_receipt", "credit" to "advance", and "record_credit_note" to "refund" |
| src/pages/Facility/billing/PaymentReconciliationSheet.tsx | Updated aria-label and button text for credit note actions to use "refund" |
| public/locale/en.json | Removed "add_credit" translation key and added "advance_receipt" translation key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/pages/Facility/billing/PaymentReconciliationSheet.tsx (1)
688-707: Inconsistent terminology: SheetTitle still uses "record_credit_note".The submit button now correctly uses
t("refund")for credit notes, but theSheetTitleat line 341 still usest("record_credit_note"). This creates a UX inconsistency where the dialog title says one thing while the action button says another.Consider updating line 341 for consistency:
Suggested fix
<SheetTitle className="m-0"> - {isCreditNote ? t("record_credit_note") : t("record_payment")} + {isCreditNote ? t("refund") : t("record_payment")} </SheetTitle>
🎭 Playwright Test ResultsStatus: ❌ Failed
📊 Detailed results are available in the playwright-final-report artifact. Run: #5101 |
|
Conflicts have been detected against the base branch. Please merge the base branch into your branch.
|
Proposed Changes
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.