Skip to content

Logic Error fixed in Solution #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 15, 2024
Merged

Logic Error fixed in Solution #72

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85067db
Logic Error fixed
SamiNasry Aug 28, 2024
3fb4576
Update loop.c to be more compact
SamiNasry Sep 12, 2024
44d3f7c
Update loop.c to be more easy to read.
SamiNasry Sep 12, 2024
12eb91d
Update loop.c
ohkimur Sep 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions chapter_2/exercise_2_02/loop.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,11 @@ int main(void)
{
char c = getchar();

if (i >= (MAXLINE - 1))
if (i >= (MAXLINE - 1) || c == '\n' || c == EOF)
{
loop = 0;
break;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamiNasry Can we have it without the break until we figure out what's up with that? I find it very educational to learn how to deal with the differences between different machines.

PS: I'm used to writing code in high-level programming languages, and I almost forgot about all these low-level implementation details.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I removed the break until we figure out why it acts like this. Thanks for your time.

}
else if (c == '\n')
{
loop = 0;
}
else if (c == EOF)
{
loop = 0;
}

s[i++] = c;
}

Expand Down
Loading