Skip to content

Implemented the loop for reading input into a string without using th… #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kkaname wants to merge 3 commits into
base: main
Choose a base branch
from
+20 −13
Open

Implemented the loop for reading input into a string without using th… #95

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb49ce7
Implemented the loop for reading input into a string without using th…
kkaname Dec 9, 2025
603ddad
Fix variable declaration for character input
kkaname Dec 9, 2025
54e8e54
Fix: enforce single-variable declarations to align with repo style.
kkaname Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions chapter_2/exercise_2_02/loop.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,30 +4,35 @@

int main(void) {
char s[MAXLINE];
int c, i = 0;

// int i;
// int c;
// for (i = 0; (i < MAXLINE - 1) * ((c = getchar()) != '\n') * (c != EOF);
// ++i)
// int i, c;
// for (i = 0; (i < MAXLINE - 1) * ((c = getchar()) != '\n') * (c != EOF); ++i)
// {
// s[i] = c;
// }

int i = 0;
int loop = 1;
while (loop) {

while (1) {
if (i >= MAXLINE - 1){
break;
}

char c = getchar();

if (i >= (MAXLINE - 1) || c == '\n' || c == EOF) {
loop = 0;
if (c == '\n'){
break;
}

s[i++] = c;
else if (c == EOF){
printf("\n");
break;
}
Comment on lines +27 to +30
Copy link

@coderabbitai coderabbitai bot Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Questionable: Extra newline printed on EOF.

Lines 25-28 print a newline when EOF is encountered, but not for other exit conditions (newline or buffer full). This creates inconsistent output behavior.

Consider whether this extra newline is necessary or if EOF should be handled like the newline case (just break).

🤖 Prompt for AI Agents 
In chapter_2/exercise_2_02/loop.c around lines 25 to 28, the code prints an
extra newline when c == EOF which causes inconsistent output compared to other
exit conditions; remove the printf("\n") so EOF is handled the same as the
newline/buffer-full cases (just break), or restructure the branch to break
immediately on EOF without emitting any characters.

else
s[i++] = c;
}

s[i] = '\0';

printf("%s", s);
printf("%s\n", s);

return 0;
}
Expand Down