Skip to content

Fixed dropping of view records in the merge process.#1314

Merged
bashir2 merged 17 commits intoohs-foundation:masterfrom
bashir2:removeStreaming-e2eDep-viewMergeBug
Mar 7, 2025
Merged

Fixed dropping of view records in the merge process.#1314
bashir2 merged 17 commits intoohs-foundation:masterfrom
bashir2:removeStreaming-e2eDep-viewMergeBug

Conversation

@bashir2
Copy link
Copy Markdown
Collaborator

@bashir2 bashir2 commented Feb 26, 2025

Description of what I changed

Fixes #1313 by looking at old DWH when for a resources ID there is no records in the newer DWH.
Please note that only the last commit belongs to this PR as it is built on top of two other PRs.

E2E test

TESTED:

Built the controller docker image locally, reproduced the bug, fixed and tested it.

Checklist: I completed these to help reviewers :)

  • I have read and will follow the review process.

  • I am familiar with Google Style Guides for the language I have coded in.

    No? Please take some time and review Java and Python style guides.

  • My IDE is configured to follow the Google code styles.

    No? Unsure? -> configure your IDE.

  • I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

  • I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

  • All new and existing tests passed.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.78%. Comparing base (6a8ac36) to head (14308d8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../java/com/google/fhir/analytics/ParquetMerger.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1314      +/-   ##
============================================
+ Coverage     50.74%   50.78%   +0.04%     
- Complexity      691      693       +2     
============================================
  Files            90       90              
  Lines          5723     5726       +3     
  Branches        774      775       +1     
============================================
+ Hits           2904     2908       +4     
  Misses         2533     2533              
+ Partials        286      285       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@chandrashekar-s chandrashekar-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bashir2 for catching this bug and fixing it. I have added few comments, can you please have a look at it.

@bashir2 bashir2 mentioned this pull request Mar 7, 2025
7 tasks
Copy link
Copy Markdown
Collaborator Author

@bashir2 bashir2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chandrashekar-s for the review. I addressed your comments and am going to merge this to make progress on the PR backlog; please let me know if you have any other comments.

@bashir2 bashir2 merged commit 6f064d2 into ohs-foundation:master Mar 7, 2025
5 checks passed
@bashir2 bashir2 deleted the removeStreaming-e2eDep-viewMergeBug branch March 8, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Records are dropped when merging view parquet files.

3 participants