Skip to content

Fixes Error prone null checks in Bunsen module#1491

Merged
bashir2 merged 18 commits intoohs-foundation:masterfrom
ndegwamartin:bunsen-nullchecks
Dec 18, 2025
Merged

Fixes Error prone null checks in Bunsen module#1491
bashir2 merged 18 commits intoohs-foundation:masterfrom
ndegwamartin:bunsen-nullchecks

Conversation

@ndegwamartin
Copy link
Copy Markdown
Collaborator

Description of what I changed

Resolves #1474

E2E test

TESTED:

Please replace this with a description of how you tested your PR beyond the
automated e2e/unit tests.

Checklist: I completed these to help reviewers :)

  • I have read and will follow the
    review process.

  • I am familiar with Google Style Guides for the language I have coded in.

    No? Please take some time and review
    Java and
    Python style guides.

  • My IDE is configured to follow the Google
    code styles.

    No? Unsure? ->
    configure your IDE.

  • I have added tests to cover my changes. (If you refactored existing
    code that was well tested you do not have to add tests)

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

  • If I made any Python code changes, I ran black . and pylint . right
    before creating this pull request and added all formatting changes to my
    commit.

  • All new and existing tests passed.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@ndegwamartin ndegwamartin requested a review from bashir2 October 6, 2025 17:24
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 47.36842% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.56%. Comparing base (684080e) to head (1a2e3a1).

Files with missing lines Patch % Lines
...erner/bunsen/definitions/StructureDefinitions.java 36.36% 2 Missing and 5 partials ⚠️
...ner/bunsen/definitions/HapiContainedConverter.java 0.00% 5 Missing ⚠️
...r/bunsen/avro/tools/GenerateAggregatedSchemas.java 0.00% 3 Missing ⚠️
...bunsen/definitions/r4/R4FhirConversionSupport.java 0.00% 1 Missing ⚠️
...en/definitions/stu3/Stu3FhirConversionSupport.java 0.00% 1 Missing ⚠️
...java/com/cerner/bunsen/ProfileMappingProvider.java 88.88% 0 Missing and 1 partial ⚠️
...a/com/cerner/bunsen/definitions/EnumConverter.java 0.00% 0 Missing and 1 partial ⚠️
...ner/bunsen/definitions/HapiCompositeConverter.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1491      +/-   ##
============================================
- Coverage     46.72%   46.56%   -0.16%     
  Complexity      677      677              
============================================
  Files            90       90              
  Lines          5875     5886      +11     
  Branches        824      834      +10     
============================================
- Hits           2745     2741       -4     
- Misses         2822     2830       +8     
- Partials        308      315       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ndegwamartin ndegwamartin marked this pull request as ready for review October 10, 2025 17:22
Copy link
Copy Markdown
Collaborator

@bashir2 bashir2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just sharing some preliminary comments as we discussed.

@ndegwamartin
Copy link
Copy Markdown
Collaborator Author

/gcbrun

@ndegwamartin
Copy link
Copy Markdown
Collaborator Author

/gcbrun

Copy link
Copy Markdown
Collaborator

@bashir2 bashir2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ndegwamartin for the changes, is this ready for another round of review? I see that you have replied to some comments and pushed some commits for addressing them but it seems not all feedback from last time are addressed; please let me know.

Copy link
Copy Markdown
Collaborator

@bashir2 bashir2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So as discussed, let's leave merging this to after we make the first release cut (we will create another candidate after merging this too).

@ndegwamartin
Copy link
Copy Markdown
Collaborator Author

/gcbrun

@ndegwamartin
Copy link
Copy Markdown
Collaborator Author

/gcbrun

Copy link
Copy Markdown
Collaborator

@bashir2 bashir2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ndegwamartin for all the changes.

@bashir2 bashir2 merged commit ae10dcc into ohs-foundation:master Dec 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix NullAway Warnings for Null Pointer Exceptions

3 participants