Fixes Error prone null checks in Bunsen module#1491
Fixes Error prone null checks in Bunsen module#1491bashir2 merged 18 commits intoohs-foundation:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1491 +/- ##
============================================
- Coverage 46.72% 46.56% -0.16%
Complexity 677 677
============================================
Files 90 90
Lines 5875 5886 +11
Branches 824 834 +10
============================================
- Hits 2745 2741 -4
- Misses 2822 2830 +8
- Partials 308 315 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bashir2
left a comment
There was a problem hiding this comment.
Just sharing some preliminary comments as we discussed.
bunsen/bunsen-avro/src/main/java/com/cerner/bunsen/avro/AvroConverter.java
Show resolved
Hide resolved
bunsen/bunsen-avro/src/main/java/com/cerner/bunsen/avro/converters/DefinitionToAvroVisitor.java
Outdated
Show resolved
Hide resolved
bunsen/bunsen-avro/src/main/java/com/cerner/bunsen/avro/tools/GenerateAggregatedSchemas.java
Show resolved
Hide resolved
|
/gcbrun |
|
/gcbrun |
bunsen/bunsen-avro/src/main/java/com/cerner/bunsen/avro/tools/GenerateAggregatedSchemas.java
Show resolved
Hide resolved
bunsen/bunsen-avro/src/test/java/com/cerner/bunsen/avro/R4AvroConverterCustomProfileTest.java
Outdated
Show resolved
Hide resolved
bunsen/bunsen-avro/src/test/java/com/cerner/bunsen/avro/R4AvroConverterUsCoreTest.java
Outdated
Show resolved
Hide resolved
...sen-core-stu3/src/main/java/com/cerner/bunsen/definitions/stu3/Stu3StructureDefinitions.java
Show resolved
Hide resolved
bunsen/bunsen-core/src/main/java/com/cerner/bunsen/ProfileMapperFhirContexts.java
Outdated
Show resolved
Hide resolved
bunsen/bunsen-core/src/main/java/com/cerner/bunsen/definitions/HapiCompositeConverter.java
Outdated
Show resolved
Hide resolved
bunsen/bunsen-core/src/main/java/com/cerner/bunsen/definitions/HapiCompositeConverter.java
Outdated
Show resolved
Hide resolved
bunsen/bunsen-core/src/main/java/com/cerner/bunsen/definitions/HapiContainedConverter.java
Outdated
Show resolved
Hide resolved
bunsen/bunsen-core/src/main/java/com/cerner/bunsen/definitions/HapiConverter.java
Show resolved
Hide resolved
bunsen/bunsen-core/src/main/java/com/cerner/bunsen/definitions/StructureDefinitions.java
Outdated
Show resolved
Hide resolved
bashir2
left a comment
There was a problem hiding this comment.
Thanks @ndegwamartin for the changes, is this ready for another round of review? I see that you have replied to some comments and pushed some commits for addressing them but it seems not all feedback from last time are addressed; please let me know.
bunsen/bunsen-core/src/main/java/com/cerner/bunsen/definitions/HapiChoiceConverter.java
Outdated
Show resolved
Hide resolved
bunsen/bunsen-core/src/main/java/com/cerner/bunsen/definitions/StructureDefinitions.java
Outdated
Show resolved
Hide resolved
bunsen/bunsen-core/src/main/java/com/cerner/bunsen/definitions/HapiCompositeConverter.java
Outdated
Show resolved
Hide resolved
bunsen/bunsen-core/src/main/java/com/cerner/bunsen/definitions/StructureDefinitions.java
Outdated
Show resolved
Hide resolved
bashir2
left a comment
There was a problem hiding this comment.
So as discussed, let's leave merging this to after we make the first release cut (we will create another candidate after merging this too).
|
/gcbrun |
bunsen/bunsen-avro/src/test/java/com/cerner/bunsen/avro/R4AvroConverterUsCoreTest.java
Outdated
Show resolved
Hide resolved
bunsen/bunsen-avro/src/test/java/com/cerner/bunsen/avro/R4AvroConverterCustomProfileTest.java
Outdated
Show resolved
Hide resolved
bunsen/bunsen-avro/src/main/java/com/cerner/bunsen/avro/AvroConverter.java
Show resolved
Hide resolved
bunsen/bunsen-avro/src/main/java/com/cerner/bunsen/avro/AvroConverter.java
Show resolved
Hide resolved
|
/gcbrun |
bashir2
left a comment
There was a problem hiding this comment.
Thanks @ndegwamartin for all the changes.
Description of what I changed
Resolves #1474
E2E test
TESTED:
Please replace this with a description of how you tested your PR beyond the
automated e2e/unit tests.
Checklist: I completed these to help reviewers :)
I have read and will follow the
review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review
Java and
Python style guides.
My IDE is configured to follow the Google
code styles.
No? Unsure? ->
configure your IDE.
I have added tests to cover my changes. (If you refactored existing
code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
If I made any Python code changes, I ran
black .andpylint .rightbefore creating this pull request and added all formatting changes to my
commit.
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master