added mutect split by chromosome tool and workflow #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
elisabethgoldman
requested changes
May 3, 2024
Collaborator
elisabethgoldman
left a comment
elisabethgoldman
left a comment
There was a problem hiding this comment.
Looks great, requested two changes as noted in comments
…cleaned id parameter, Added merge files with bcftools tool and worflow
edited output formatting.
fixed typo
Concatenate across chromosomes, zip, and index
elisabethgoldman
approved these changes
May 8, 2024
Collaborator
elisabethgoldman
left a comment
elisabethgoldman
left a comment
There was a problem hiding this comment.
This looks great!
Only comment is relatively low priority, but is about renaming the read_orientation_model param to make it clearer that it's referring to the output of learnReadOrientationModel (the specific new name I'd like to use is in the comment itself). Otherwise good to go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.