fix: correctly parse all examples using LINE_PATTERN with named groups#6
Open
dupuy wants to merge 3 commits intooijkn:mainfrom
Open
fix: correctly parse all examples using LINE_PATTERN with named groups#6dupuy wants to merge 3 commits intooijkn:mainfrom
dupuy wants to merge 3 commits intooijkn:mainfrom
Conversation
The CSV output from aws-nuke-exporter has CRLF line endings, (that is the default for the Python csv module). Depending on Git configuration, the CR may be removed. You can use the --ignore-space-at-eol option to get more useful output from 'git diff' in that case.
Update generated CSV and JSON sample_output files.
Update generated CSV and JSON sample_output files.
dupuy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A more complete fix for #3:
fix: update CSV sample_output file with output from version 1.0.3
The CSV output from aws-nuke-exporter has CRLF line endings, (that is the default for the Python csv module). Depending on Git configuration, the CR may be removed.
You can use the
--ignore-space-at-eol optionto get more useful output fromgit diffin that case.fix: use correct format for ECSTask resource in sample output text
Update generated CSV and JSON sample_output files.
fix: correctly parse all examples using LINE_PATTERN with named groups
Update generated CSV and JSON sample_output files.