Skip to content

Remove global buffer use#3

Merged
taoeffect merged 3 commits intomainfrom
no-global-buffer
Jun 8, 2025
Merged

Remove global buffer use#3
taoeffect merged 3 commits intomainfrom
no-global-buffer

Conversation

@corrideat
Copy link
Member

Remove use of Buffer to avoid needing dependencies or polyfills, as well as removing the need to define variables in the global scope.

@socket-security
Copy link

socket-security bot commented Jun 7, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​typescript-eslint/​eslint-plugin@​8.21.0 ⏵ 8.33.19910078 +197100
Updatedtypescript@​5.7.3 ⏵ 5.8.3100 +110089 +1100100

View full report

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only one minor change request regarding how we handle dependencies (avoiding the use of ^ should be a standard thing across all our projects)

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Meant to click "Request changes", not "Comment"

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @corrideat! I can merge as-is or wait for one minor adjustment, your call.

@taoeffect taoeffect merged commit 9f7acc6 into main Jun 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants