Skip to content

fix: speed up gopls lint with install optimization and optional parallelism #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taoeffect merged 6 commits into from
Feb 2, 2026
Merged

fix: speed up gopls lint with install optimization and optional parallelism #123

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9a94079
fix: speed up gopls lint with parallel processing
devin-ai-integration[bot] Jan 21, 2026
785fe19
ci: add lint steps before tests in pull-tests workflow
devin-ai-integration[bot] Jan 21, 2026
cadf8a0
revert: remove lint steps from pull-tests.yml
devin-ai-integration[bot] Jan 21, 2026
601465c
fix: address PR review comments for gopls lint script
devin-ai-integration[bot] Jan 21, 2026
01a0d12
fix: make gopls parallelism configurable, default to 1
devin-ai-integration[bot] Jan 23, 2026
fa4b6d4
fix: handle GOBIN env var and enable parallelism in CI
devin-ai-integration[bot] Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tools/lint-go-gopls.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,18 @@ IGNORE_PATTERNS=(
"is deprecated" # TODO: fix these
)

# Install gopls if not already installed, then use the installed binary for
# faster execution. Using 'go run' each time adds overhead.
"$GO" install "$GOPLS_PACKAGE" 2>/dev/null
GOPLS_BIN=$("$GO" env GOPATH)/bin/gopls

# lint all go files with 'gopls check' and look for lines starting with the
# current absolute path, indicating a error was found. This is necessary
# because the tool does not set non-zero exit code when errors are found.
# ref: https://github.com/golang/go/issues/67078
ERROR_LINES=$("$GO" run "$GOPLS_PACKAGE" check -severity=warning "$@" 2>/dev/null | grep -E "^$PWD" | grep -vFf <(printf '%s\n' "${IGNORE_PATTERNS[@]}"));
# Use xargs with parallel execution (-P) to speed up checking many files.
# Each batch of 100 files is processed in parallel across available cores.
ERROR_LINES=$(printf '%s\n' "$@" | xargs -P "$(nproc)" -n 100 "$GOPLS_BIN" check -severity=warning 2>/dev/null | grep -E "^$PWD" | grep -vFf <(printf '%s\n' "${IGNORE_PATTERNS[@]}"));
NUM_ERRORS=$(echo -n "$ERROR_LINES" | wc -l)

if [ "$NUM_ERRORS" -eq "0" ]; then
Expand Down