-
Notifications
You must be signed in to change notification settings - Fork 0
wiki2md: use file modification for commit timestamps on article import #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3ce8223 to
bf8dacb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the article-creator service to set the initial commit timestamp for imported Wikipedia articles based on the source Markdown file’s modification time (as produced by wiki2md), aligning repository history with when the article was fetched/written to disk.
Changes:
- Read the Markdown file’s filesystem modification time during import.
- Pass that timestamp into README creation and use it for the commit’s author/committer dates.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Great work @pedrogaudencio! Minor suggestion from Opus 4.6, you can take it or leave it (let me know!) DetailsThe change is small and straightforward. I found one concrete issue and one minor simplification. 1. TOCTOU race and redundant syscall with
|
* eliminates race condition where file could change between stat and read
taoeffect
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
Uses time of article file modification (upon being imported with
wiki2mdtool) as first commit timestamp upon Wikipedia article creation.Following discussion in /pull/127 and @eighttrigrams's suggestion.