Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
134 commits
Select commit Hold shift + click to select a range
7e6db8e
editor: implement fork-on-edit workflow for article editing
pedrogaudencio Dec 13, 2025
fa785a6
editor: prevent editing fork when user owns repo for same subject
pedrogaudencio Dec 13, 2025
49e1cf3
editor: remove unused form parameter from handleForkAndEdit
pedrogaudencio Dec 16, 2025
bd3ef94
editor: fix getUniqueRepositoryName bugs and optimize
pedrogaudencio Dec 16, 2025
ba5bb2a
fork: parallelize permission queries
pedrogaudencio Dec 16, 2025
8b5c32d
fork: add ErrUserOwnsSubjectRepo error type
pedrogaudencio Dec 16, 2025
a64a811
editor: consolidate fork-on-edit permission logic
pedrogaudencio Dec 15, 2025
420c618
templates: update article editing logic
pedrogaudencio Dec 15, 2025
1f5ef1d
migrations: add composite indexes for fork-on-edit optimization
pedrogaudencio Dec 16, 2025
ecac092
editor: improve fork-on-edit error messages in templates
pedrogaudencio Dec 16, 2025
ca4a41a
i18n: replace hardcoded strings with translation variables in article…
pedrogaudencio Dec 16, 2025
76e4fa3
Merge branch 'master' into change-request-fork-article
pedrogaudencio Dec 17, 2025
35c540a
templates: add translation keys and simplify logic
pedrogaudencio Dec 18, 2025
b760e1a
article: add confirmation modal to fork article button
pedrogaudencio Dec 19, 2025
77adece
article: add tooltip to Fork button
pedrogaudencio Dec 19, 2025
0ea2562
Merge branch 'master' into change-request-fork-article
pedrogaudencio Dec 19, 2025
d0438c4
tests: add e2e tests for fork article
pedrogaudencio Dec 20, 2025
7c688f1
tests: add fork-on-edit permission e2e tests
pedrogaudencio Dec 20, 2025
246e58f
tests: add edge case and accessibility tests for fork article modal
pedrogaudencio Dec 20, 2025
352d5a5
editor: fix fork-and-edit workflow for non-owners
pedrogaudencio Dec 21, 2025
28828f9
tests: fork-and-edit workflow
pedrogaudencio Dec 21, 2025
f1162b0
tests: add database migration tests for v326 and v327
pedrogaudencio Dec 21, 2025
4b1b055
api: add tests for fork with subject conflict and fix error handling …
pedrogaudencio Dec 21, 2025
9f8de0d
permissions: restrict fork_and_edit bypass to _edit and _new actions …
pedrogaudencio Dec 21, 2025
e699e2b
tests: add fork-on-edit permission tests
pedrogaudencio Dec 21, 2025
f0efd14
fork: replace type assertion with wrapped error support
pedrogaudencio Dec 21, 2025
90a12c6
templates: document fallback logic
pedrogaudencio Dec 21, 2025
fc3ee6c
repo: return errors from GetForkedRepo
pedrogaudencio Dec 21, 2025
2d929e2
linting: fix issues
pedrogaudencio Dec 22, 2025
3cc6c00
tests: use slices instead of forloop
pedrogaudencio Dec 22, 2025
a6a3609
tests: fix ESLint and TypeScript errors
pedrogaudencio Dec 22, 2025
1bcad13
tests: fix toastui-editor selector
pedrogaudencio Dec 22, 2025
482f29f
fork-on-edit: address code review findings
pedrogaudencio Dec 22, 2025
683b99c
editor: implement submit-change-request for article contributions
pedrogaudencio Dec 26, 2025
eb94795
permission: allow submit_change_request to bypass branch write check
pedrogaudencio Dec 27, 2025
56fc001
editor: fix log message format
pedrogaudencio Dec 27, 2025
5930277
editor: validate repository allows pull requests
pedrogaudencio Dec 27, 2025
f7cde0d
editor: add content validation
pedrogaudencio Dec 27, 2025
195e8aa
tests: update fork-article-modal tests to use new button ID
pedrogaudencio Dec 27, 2025
a2771ee
tests: add submit-change-request workflow tests
pedrogaudencio Dec 27, 2025
640bd80
Merge branch 'master' into change-request-submit-edits
pedrogaudencio Dec 31, 2025
31fd907
editor: add InternalPush option for submit-change-request workflow
pedrogaudencio Jan 7, 2026
616e3f4
tests: fix E2E tests for submit-change-request
pedrogaudencio Jan 7, 2026
9717367
tests: fix linting in submit-change-request
pedrogaudencio Jan 7, 2026
f72d390
pull: restrict merge operations to repository owners only
pedrogaudencio Jan 12, 2026
8252c48
pull: enforce squash-only merge strategy
pedrogaudencio Jan 12, 2026
2d56114
editor: add custom title and description for Change Request
pedrogaudencio Jan 12, 2026
dccb1fe
editor: add modal UI for Change Request title and description
pedrogaudencio Jan 12, 2026
cebf2ec
tests: suppress linting warnings in submit-change-request
pedrogaudencio Jan 8, 2026
1f4cd60
fix: use distinct button IDs and correct E2E test selectors
pieer Jan 18, 2026
1147017
fix: use translation key for content required error message
pieer Jan 18, 2026
d41cbc9
fix: add explicit authentication check in handleSubmitChangeRequest
pieer Jan 18, 2026
3f4f7af
fix: validate mutually exclusive fork_and_edit and submit_change_requ…
pieer Jan 18, 2026
7cfaf6f
docs: fix integration test comment about middleware behavior
pieer Jan 18, 2026
690af3c
tests: fix selector for Submit Change Request button
pedrogaudencio Jan 19, 2026
72295a1
Merge branch 'master' into change-request-submit-edits
pedrogaudencio Jan 19, 2026
533bc9a
editor: validate empty content in submit change request
pedrogaudencio Jan 20, 2026
fde90ed
editor: add CR title length validation
pedrogaudencio Jan 20, 2026
c26bb85
editor: cleanup orphaned branch on CR creation failure
pedrogaudencio Jan 20, 2026
fc38846
tests: branch cleanup on CR failure
pedrogaudencio Jan 20, 2026
61f6a29
tests: whitespace-only content rejection
pedrogaudencio Jan 20, 2026
96b75b1
linting: fix issues
pedrogaudencio Jan 20, 2026
0c35e5e
Remove side bar from the pull request
pieer Jan 20, 2026
03ffb69
Merge remote-tracking branch 'origin/change-request-submit-edits' int…
pieer Jan 20, 2026
5d53117
tests: add concurrent branch collision test for submit-change-request
pedrogaudencio Jan 20, 2026
a692d1b
linting: fix issues
pedrogaudencio Jan 20, 2026
44ac07c
Fix linting
pieer Jan 20, 2026
5268250
Merge remote-tracking branch 'origin/change-request-submit-edits' int…
pieer Jan 20, 2026
6774a47
Merge branch 'master' into change-request-submit-edits
pedrogaudencio Jan 21, 2026
6d4c620
actions: fix empty Ref warning for workflow_run events
pedrogaudencio Jan 23, 2026
efccbc0
templates: move issue view changes to custom overrides
pedrogaudencio Jan 23, 2026
ff9507e
routers: fix nil pointer dereference
pedrogaudencio Jan 23, 2026
768f3a6
tests: fix submit-change-request concurrent test assumptions
pedrogaudencio Jan 23, 2026
fb9a746
pull: allow non-collaborator CR creation for submit-change-request wo…
pedrogaudencio Jan 23, 2026
783a860
editor: fix submit-change-request creating PRs in wrong repository
pedrogaudencio Jan 23, 2026
e840bd1
locale: update change request copy
pedrogaudencio Jan 23, 2026
6587c67
editor: fix orphaned branches when OpenRepository or GetCompareInfo f…
pedrogaudencio Jan 23, 2026
206c8d1
editor: fix UTF-8 corruption in PR title truncation
pedrogaudencio Jan 23, 2026
d8b3989
fork-on-edit: allow change requests from users with existing forks
pedrogaudencio Jan 22, 2026
45d5579
editor: add permission validation for submit change request
pedrogaudencio Jan 26, 2026
72a7e0b
locale: standardize key
pedrogaudencio Jan 26, 2026
a4c076e
templates: use conditionally show submit button
pedrogaudencio Jan 26, 2026
3a15324
tests: add unit and integration tests for fork-on-edit permissions
pedrogaudencio Jan 26, 2026
8b5f8a5
Merge branch 'master' into change-request-submit-edits
pedrogaudencio Jan 26, 2026
4106871
editor: fix PushOutOfDate error
pedrogaudencio Jan 26, 2026
40f7757
locale: fix typos
pedrogaudencio Jan 26, 2026
6e7f1dc
editor: remove redundant cleanup
pedrogaudencio Jan 26, 2026
c008863
tests: fix hardcoded PR index
pedrogaudencio Jan 26, 2026
993c789
editor: extract duplicate branch cleanup logic to helper function
pedrogaudencio Jan 26, 2026
97a7013
editor: add specific error message for mutually exclusive workflow flags
pedrogaudencio Jan 26, 2026
0074378
editor: add PR description length limit for change requests
pedrogaudencio Jan 26, 2026
9bd5481
Merge branch 'change-request-submit-edits' into change-request-if-for…
pedrogaudencio Jan 26, 2026
a51b362
Merge branch 'master' into change-request-if-fork-owner
taoeffect Jan 27, 2026
c7e7815
Update tooltip color and message
pieer Jan 27, 2026
743b0b4
Update message after fork
pieer Jan 27, 2026
8409ea3
Merge branch 'master' into update-fork-design
pieer Feb 3, 2026
d0bf97a
Fix table ui
pieer Feb 3, 2026
890449c
Change WYSIWYG
pieer Feb 3, 2026
5f26b57
Update owner review header
pieer Feb 3, 2026
4417843
Update button style
pieer Feb 3, 2026
84c3ca8
Update copy and design
pieer Feb 10, 2026
84b6edc
Style split view
pieer Feb 10, 2026
7e5f2cf
Update Submit review into popup box
pieer Feb 10, 2026
0533e20
Customize combo-markdown-editor
pieer Feb 10, 2026
8c0c118
routers: fix comment form action url and add missing article-namespac…
pedrogaudencio Feb 12, 2026
9324b9c
routers: remove redundant middleware
pedrogaudencio Feb 16, 2026
15a3486
Update PR comment form buttons and styling
pieer Feb 17, 2026
d9d97a0
Merge origin/master
pieer Feb 17, 2026
8d66f14
Fix overlay on the popup when a comment box is open the markdown editor
pieer Feb 17, 2026
bb52a20
Merge remote-tracking branch 'origin/change-request-fix-comments' int…
pieer Feb 17, 2026
8f5b4f0
Merge remote-tracking branch 'origin/master' into update-fork-design
pieer Feb 23, 2026
56ac1b1
attempt to fix the failing tests
pieer Feb 23, 2026
b81d369
feat: Localize the pull request review modal and diff headers, and re…
pieer Feb 23, 2026
d3b7f21
refactor: rename new_review.tmpl to review_submit.tmpl
pieer Feb 23, 2026
041e0b2
refactor: Introduce and apply CSS variables for standardized color an…
pieer Feb 23, 2026
bef9328
Fix test
pieer Feb 24, 2026
3567206
Fix split view
pieer Feb 24, 2026
5949316
repo: fix missing middleware
pedrogaudencio Feb 25, 2026
1f5f6a6
routers: add register pull request helper
pedrogaudencio Feb 25, 2026
1d0ce30
templates: fix review button condition
pedrogaudencio Feb 26, 2026
c8fd1ff
repo: add type assertion fix
pedrogaudencio Feb 26, 2026
7b8e4f8
Merge branch 'master' into change-request-fix-diff-comments
pedrogaudencio Feb 27, 2026
ac9b32e
Fix PR review feedback: navbar pill active state and review button au…
pieer Mar 2, 2026
88d1e54
Fix test: render review button for all PR file views
pieer Mar 2, 2026
74d546b
fix: add missing data-fork-confirm-body2 attribute in article template
pieer Mar 2, 2026
6386b89
fix: remove unused review title field from review modal
pieer Mar 2, 2026
2baef0f
cleanup: remove commented-out CSS and orphaned media query
pieer Mar 2, 2026
207b399
fix: replace inline onclick handlers with event listeners
pieer Mar 2, 2026
872ae5e
fix: add Escape key handler for review modal (accessibility)
pieer Mar 2, 2026
9bf3d0d
i18n: replace hardcoded English strings with locale lookups
pieer Mar 2, 2026
b714f3b
fix: prevent mobile redirect loop on PR files page
pieer Mar 2, 2026
23d4c1d
Merge remote-tracking branch 'origin/master' into update-fork-design
pieer Mar 3, 2026
464f8f5
Merge branch 'update-fork-design' into change-request-fix-diff-comments
pedrogaudencio Mar 3, 2026
8cb95af
Merge branch 'master' into change-request-fix-diff-comments
pedrogaudencio Mar 3, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion routers/web/repo/pull.go
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,8 @@ func viewPullFiles(ctx *context.Context, beforeCommitID, afterCommitID string) {
"numberOfViewedFiles": diff.NumViewedFiles,
}

if err = diff.LoadComments(ctx, issue, ctx.Doer, ctx.Data["ShowOutdatedComments"].(bool)); err != nil {
showOutdatedComments, _ := ctx.Data["ShowOutdatedComments"].(bool)
if err = diff.LoadComments(ctx, issue, ctx.Doer, showOutdatedComments); err != nil {
ctx.ServerError("LoadComments", err)
return
}
Expand Down
3 changes: 2 additions & 1 deletion routers/web/repo/pull_review.go
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@ func UpdateResolveConversation(ctx *context.Context) {
func renderConversation(ctx *context.Context, comment *issues_model.Comment, origin string) {
ctx.Data["PageIsPullFiles"] = origin == "diff"

showOutdatedComments := origin == "timeline" || ctx.Data["ShowOutdatedComments"].(bool)
showOutdatedComments, _ := ctx.Data["ShowOutdatedComments"].(bool)
showOutdatedComments = origin == "timeline" || showOutdatedComments
comments, err := issues_model.FetchCodeCommentsByLine(ctx, comment.Issue, ctx.Doer, comment.TreePath, comment.Line, showOutdatedComments)
if err != nil {
ctx.ServerError("FetchCodeCommentsByLine", err)
Expand Down
Loading