request flow

[bikubi]

it's a lot!

companion: okfde/fragdenstaat_de#920

[krmax44]

Seems like migrations are missing.

[krmax44]

The find similar requests step might currently be a bit confusing, as there's no description of what the user should do. The input field has no placeholder.

Instead of "Continue" (Weiter), maybe the button should say "Skip". Maybe after some time, a little encouragement should pop up ("The information you're looking for isn't available yet? Then let's request it!"), to avoid users getting stuck here.

Low prio/think about it later: Not sure if the "Campaign" filter is that useful here, actually.

[bikubi]

The find similar requests step might currently be a bit confusing, as there's no description of what the user should do. The input field has no placeholder.

Instead of "Continue" (Weiter), maybe the button should say "Skip". Maybe after some time, a little encouragement should pop up ("The information you're looking for isn't available yet? Then let's request it!"), to avoid users getting stuck here.

Changed "next" to "skip".

• if popup, where, how? tooltip for the "skip" button?
• or after the first search, the lower skip button changes back to "next" and gains a help text "The info... let's request it!")
• or maybe, just an (over)emphasized "(optional)" in the heading: "Find similar requests (optional)"?

Low prio/think about it later: Not sure if the "Campaign" filter is that useful here, actually.

yeah, if taken at strict filter face value... but it also sneakily serves as a neat "look at all our campaigns" browser?

[krmax44]

It's looking really great! Two nitpicks & 1 bug before merge:

1. Layout on mobile is sometimes bit off:
   
2. Let's move the continue button of the multi-chooser also to the top right, like in the other steps, and remove the "Add more public bodies" button in the following ("3.2") step (redundant with the back button).
   
3. When creating an account, I can't continue in step 4 (when writing the request), the submit button doesn't work (TypeError: can't access property "validate", this.$refs.userConfirm is undefined). I initially didn't tick the TOS checkbox, maybe it has to do with that. We should probably address all these new branches in e2e tests after merging.

[bikubi]

@krmax44

Two nitpicks & 1 bug before merge:

nitpicks attended to, plus two bonus minor touch-ups, bug fixed. Context for the latter..

3. When creating an account, I can't continue in step 4 (when writing the request), the submit button doesn't work (TypeError: can't access property "validate", this.$refs.userConfirm is undefined). I initially didn't tick the TOS checkbox, maybe it has to do with that. We should probably address all these new branches in e2e tests after merging.

It was the optional (fds_de vs froide) free-form confirm checkbox that I forgot could be absent when the static_alias is empty.
Tangentially - when trying to test the fix properly I had trouble creating the static_aliases, or well, more trouble than last time. Let's keep that in mind for deployment.