Skip to content
This repository was archived by the owner on May 19, 2022. It is now read-only.

express oauth2 bearer update#59

Open
NotMyself wants to merge 3 commits intomainfrom
feat/express-oauth2-bearer-update
Open

express oauth2 bearer update#59
NotMyself wants to merge 3 commits intomainfrom
feat/express-oauth2-bearer-update

Conversation

@NotMyself
Copy link
Contributor

@NotMyself NotMyself commented Oct 26, 2021

The express-oauth2-bearer package is being renamed to express-oauth2-jwt-bearer. This PR makes the source changes needed to switch to the new dependency.

Prior to merging, Absorb needs to be updated. See comment below.

@NotMyself
Copy link
Contributor Author

@auth0aaron Before I can merge these changes the existing labs in absorb will need to be updated. These slides need to be updated to reference express-oauth2-jwt-bearer instead of express-oauth2-bearer.

Screen Shot 2021-10-26 at 11 13 56 AM

Screen Shot 2021-10-26 at 11 13 45 AM

Screen Shot 2021-10-26 at 11 11 53 AM

@NotMyself
Copy link
Contributor Author

@adamjmcgrath when this PR is merged the current labs will be migrated to the new express-oauth2-jwt-bearer dependency. I will still need to update our new labs that are in progress. I will let you know when complete.

@NotMyself
Copy link
Contributor Author

NotMyself commented Oct 26, 2021

It looks like there are differences between the packages. The ALLOWED_AUDIENCES envvar was changed to AUDIENCE which will ripple to quite a few changes.

@adamjmcgrath
Copy link

lgtm thanks @NotMyself

The ALLOWED_AUDIENCES envvar was changed to AUDIENCE which will ripple to quite a few changes.

Yep - this env var has changed. apologies...

@NotMyself
Copy link
Contributor Author

No worries @adamjmcgrath. We use magic links to deploy into Vercel. These links reference the required envvars. So they will need to be updated as well. So it will take a bit longer than anticipated but not a big deal.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants