Skip to content

Conversation

@Astro2024
Copy link

@Astro2024 Astro2024 commented Oct 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Currently, there are two ways to initialize the Okta client within the okta-sdk. The first is using an api token and the second is using a public private key pair.

Issue Number: N/A

What is the new behavior?

This PR allows someone using the okta-sdk to initialize the Okta client using client id and client secret in addition to the previous two methods mentioned.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

@jefftaylor-okta

@Astro2024
Copy link
Author

@ryanbradley

@jefftaylor-okta
Copy link

@jaredperreault-okta Can you have a look at this PR?

bretterer
bretterer previously approved these changes Nov 14, 2024
@Astro2024
Copy link
Author

@bretterer I cleaned up the commits so they would all be verified as per you repo merge rules. Can you re-approve the PR since your initial review was dropped after I cleaned up the commits?

@willpots
Copy link

willpots commented Dec 4, 2024

@bretterer thanks for the review here- for some reason, @Astro2024 and I can't merge this PR. Anything else we need to do?
Screenshot 2024-12-04 at 10 56 10 AM

@Astro2024
Copy link
Author

@jaredperreault-okta are there any other steps we need to take to get this PR Merged?

@Astro2024
Copy link
Author

@bretterer @jaredperreault-okta Bump

@baileywickham
Copy link

Hey, any updates on this? We could really use this. Thanks!

@Astro2024
Copy link
Author

@bretterer @jefftaylor-okta @jaredperreault-okta Is there a timeline for when this PR can be merged or is there currently a moratorium on PR merges?

@Astro2024
Copy link
Author

@bretterer @jefftaylor-okta @jaredperreault-okta Any updates on when this might be able to go in?

@mplachter
Copy link

Any updates on when this can go in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants