This repository was archived by the owner on Jan 26, 2025. It is now read-only.
Make applicationGroupAssignment null by default.#134
Open
bijanmmarkes wants to merge 1 commit intookta:developfrom
Open
Make applicationGroupAssignment null by default.#134bijanmmarkes wants to merge 1 commit intookta:developfrom
bijanmmarkes wants to merge 1 commit intookta:developfrom
Conversation
Adjusting applicationGroupAssigned as optional field to match Official Okta API documentation.
|
This is much needed! 👍 |
Contributor
|
Thank you for the PR. This will have to be adjusted in our openapi spec in order to update it here. We will llook at how we can improve this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusting applicationGroupAssignment as optional field for the createApplicationGroupAssignment() function to match Official Okta API documentation.
Pull Request for issue #133
The latest version of this SDK currently requires the ApplicationGroupsAssignment:
Okta\Generated\Applications\ApplicationGroupAssignmentThis would be okay, but the issue is that is causes PSR7 to throw an exception:
\PSR7\Stream.php:88:First argument to Stream::create() must be a string, resource or StreamInterface.The current Okta API documentation claims that ApplicationGroupsAssignment is not a required field, and even if we wanted to pass it as a parameter, the action would fail due to the error mentioned above.
I suggest making the ApplicationGroupAssignment an optional parameter, just as it is in the Okta Java SDK.
It could just be that i'm initializing it incorrectly, but there's no documentation and I've attempted various ways all with no success.