Fix client creds auth #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okta#424 seems to break client creds based auth because it uses create_request() wrong, which will lead to a POST request to /oauth2/v1/token with a JSON body, content-type application/json. But this endpoint does not accept this content-type and returns with 'Accept and/or Content-Type headers likely do not match supported values.'. Instead it expects the content-type to be 'application/x-www-form-urlencoded', and the client assertion needs to be form encoded. This corrects that issue.
Contributor
|
@csanders-git Thank you for your contribution! I will work to get this change merged and and a new version published. |
Merged
Contributor
|
@csanders-git To cover our bases please sign a CLA and submit to [email protected]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#424 seems to break client creds based auth because it uses create_request() wrong, which will lead to a POST request to /oauth2/v1/token with a JSON body, content-type application/json. But this endpoint does not accept this content-type and returns with 'Accept and/or Content-Type headers likely do not match supported values.'. Instead it expects the content-type to be 'application/x-www-form-urlencoded', and the client assertion needs to be form encoded. This corrects that issue.