Fixed #435: added data_type parameter for OktaAPIResponse #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 13, 2025 18:58
… next_response has a type consistent with the previous response.
- fixes test_response_pagination_with_next_include_response failure
manmohan-shaw-okta
approved these changes
Mar 28, 2025
BinoyOza-okta
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #435: added
data_typeparameter forOktaAPIResponseThe title and initial description blame
has_next, but later comments clarify the issue is with inconsistent typing of results between pages. Added a unit test to show that the master branch currently has inconsistent types between pages. Resolved the issue by addingdata_typeparameter toOktaAPIResponse.I've emailed a signed CLA.