Skip to content

"Okta direct auth API grants" are not valid OAuthGrantType #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BinoyOza-okta merged 1 commit into from
Mar 28, 2025
Merged

"Okta direct auth API grants" are not valid OAuthGrantType #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions okta/models/o_auth_grant_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,7 @@ class OAuthGrantType(
DEVICE_CODE = "urn:ietf:params:oauth:grant-type:device_code", "URN:IETF:PARAMS:OAUTH:GRANT-TYPE:DEVICE_CODE"
TOKEN_EXCHANGE = "urn:ietf:params:oauth:grant-type:token-exchange", "URN:IETF:PARAMS:OAUTH:GRANT-TYPE:TOKEN-EXCHANGE"
INTERACTION_CODE = "interaction_code", "INTERACTION_CODE"
OTP = "urn:okta:params:oauth:grant-type:otp", "URN:OKTA:PARAMS:OAUTH:GRANT-TYPE:OTP"
OOB = "urn:okta:params:oauth:grant-type:oob", "URN:OKTA:PARAMS:OAUTH:GRANT-TYPE:OOB"
MFA_OTP = "http://auth0.com/oauth/grant-type/mfa-otp", "HTTP://AUTH0.COM/OAUTH/GRANT-TYPE/MFA-OTP"
MFA_OOB = "http://auth0.com/oauth/grant-type/mfa-oob", "HTTP://AUTH0.COM/OAUTH/GRANT-TYPE/MFA-OOB"
25 changes: 22 additions & 3 deletions tests/unit/test_applications_ut.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ async def mock_response_text():
}
)
provisioning_conn_req = models.ProvisioningConnectionRequest({'profile': profile})
_ = await client.set_default_provisioning_connection_for_application('test_app_id', provisioning_conn_req, query_params={'activate': True})
_ = await client.set_default_provisioning_connection_for_application('test_app_id', provisioning_conn_req,
query_params={'activate': True})
assert mock_http_request.request_info['url'].endswith('/apps/test_app_id/connections/default/?activate=True')
data = mock_http_request.request_info['data']
assert json.loads(data) == {"profile": {"authScheme": "TOKEN", "token": "TEST"}}
Expand Down Expand Up @@ -133,6 +134,7 @@ async def mock_response_text():
assert isinstance(features[0].capabilities.update.password.change, models.ChangeEnum)
assert isinstance(features[0].status, models.EnabledStatus)


@pytest.mark.asyncio
async def test_get_feature_for_application(monkeypatch, mocker):
mocked_response = """{
Expand Down Expand Up @@ -256,10 +258,10 @@ async def mock_response_text():
"lifecycleDeactivate": {
"status": "ENABLED"
},
"profile":{
"profile": {
"status": "ENABLED"
},
"password":{
"password": {
"status": "ENABLED",
"seed": "RANDOM",
"change": "CHANGE"
Expand Down Expand Up @@ -313,3 +315,20 @@ async def mock_response_text():
assert mock_http_request.request_info['url'].endswith('/apps/test_app_id/logo')
data = mock_http_request.request_info['data']
assert data == {'file': logo}

class TestOAuthGrantType:
"""
Unit Tests for the OAuthGrantType Enum
"""

def test_new_enum_types(self):
# List of new ENUM types to be tested
new_enum_types = [
"urn:okta:params:oauth:grant-type:otp",
"urn:okta:params:oauth:grant-type:oob",
"http://auth0.com/oauth/grant-type/mfa-otp",
"http://auth0.com/oauth/grant-type/mfa-oob"
]

for enum_type in new_enum_types:
assert enum_type in models.OAuthGrantType.__members__.values()