Skip to content

security: replace unsafe YAML loading with safe_load to prevent RCE #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RinZ27 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −8
Open

security: replace unsafe YAML loading with safe_load to prevent RCE #483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions okta/okta_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,10 @@
import os
from pathlib import Path

from yaml import load
import yaml

from okta.configuration import Configuration

try:
from yaml import CLoader as Loader
except ImportError:
from yaml import Loader


class OktaConfiguration():
"""
Expand All @@ -43,8 +38,9 @@ def get_configuration(self) -> Configuration:

def read_configuration(self, file_path) -> Configuration:
if Path(file_path).is_file():
text = open(file_path).read()
okta_config = load(text, Loader=Loader)
with open(file_path, 'r') as f:
text = f.read()
okta_config = yaml.safe_load(text)
config = Configuration()
config.host = okta_config['oktaDomain']
config.api_key['apiToken'] = okta_config['apiKey']
Expand Down