Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to upstream go-ethereum maintainers and after an analysis, though
SortedMapis not thread-safe, the upper design pattern has dealt with the concurrent access. Modifying methods likePutandForwardare warped byLockin the upper callers. AndFlattenis read only method, in which the cache is protected by its ownm.cacheMu.Lock.Plus,
ContentFrommethod already usesRLock, so it's safe to do this conversion.ethereum/go-ethereum#32924
This PR in go-ethereum is highly likely to be merged. We can modify this at first.