Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the Excalidraw canvas is zoomed to 100% on load by overriding the appState.zoom value.
- Force
appState.zoomto 1 during compilation - Ensures drawing fits properly within the viewport
Comments suppressed due to low confidence (1)
src/compiler/ExcalidrawCompiler.ts:59
- Add or update unit tests to verify that
appState.zoomis correctly overridden to1during the compilation process.
excaliDrawJson.appState?.zoom = { value: 1}
uroybd
force-pushed
the
excalidraw-zoom-fix
branch
from
8cc778e to
cc934a1
Compare
Contributor
Author
|
I'm getting lint errors on files I haven't touched. |
Contributor
Author
|
Hello @oleeskild! Can we get this merged? |
oleeskild
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will override the zoom state to 1 to fit the drawing properly on load.