fix(ui): respect opts.visible for non-"system" roles

[stormc]

Description

opts.visible is not respected for non-"system" roles in chat.

Related Issue(s)

• Fixes [Bug]: opts.visible is not respected for non-"system" roles in chat #1203

Checklist

• I've read the contributing guidelines and have adhered to them in this PR
• I've updated the README and/or relevant docs pages
• I've run make docs to update the vimdoc pages

[olimorris]

Brilliant spot! Thanks for investigating and solving.

[petobens]

Hi! Sorry but I don't quite get this change. Before the change if write a prompt like

 [' Bash Developer'] = {
            strategy = 'chat',
            description = 'Act as an expert Bash developer.',
            opts = {
                short_name = 'bash_role',
                is_slash_cmd = true,
                auto_submit = false,
                ignore_system_prompt = true,
            },
            prompts = {
                {
                    role = 'system',
                    content = [[
You are an expert Bash developer.
When giving code examples show the generated output.
]],
                    opts = { visible = true },
                },
                {
                    role = 'user',
                    content = [[]],
                },
            },
        }

and then as in the GIF invoke the action palette and run the prompt then i) the system prompt would be visible and ii) the opts = { visible = false } flag would make it invisible. However with the change in this commit the content is always invisible and the opts.visible flag doesn't seem to be honored.

[olimorris]

Yes I've noticed this has caused intended consequences with CodeCompanionChat. I've reverted this for now with #1218.