Skip to content

Conversation

@meronogbai
Copy link
Contributor

@meronogbai meronogbai commented Apr 6, 2025

Description

I wanted codecompanion to respect .gitignore when selecting files via the /file slash command. I initially thought this was a missing feature, but I managed to get it working by using telescope as the provider. Most likely because I had configured Telescope to respect ignore files globally.

This was surprising because I assumed codecompanion already used telescope by default. So I figured, why not make that behavior official?

Related Issue(s)

#1185

Checklist

  • I've read the contributing guidelines and have adhered to them in this PR
  • I've updated the README and/or relevant docs pages
  • I've run make docs to update the vimdoc pages

@meronogbai
Copy link
Contributor Author

Running make docs adds unrelated changes and I couldn't update docs because I don't know which files I should update. 👀

@olimorris
Copy link
Owner

Can we keep this as config.lua please. Don't understand why you've renamed it to config/init.lua. This is a great PR but doesn't need a structure change.

@olimorris
Copy link
Owner

We also need to document this for other users, in the configuration section of the docs

@meronogbai
Copy link
Contributor Author

@olimorris Done! LMK what you think 🫡

@olimorris
Copy link
Owner

So this is very, very awesome and will clean up people's config tremendously. Thanks for your efforts! Worked out of the box brilliantly for me and will be a huge improvement on the default experience for a lot of people.

I've added in some minor comments.

@meronogbai
Copy link
Contributor Author

TY @olimorris. For some reason, I can't see the comments. Did you forget to click the submit review button?

image

@olimorris
Copy link
Owner

Me right now

image

@meronogbai meronogbai requested a review from olimorris April 7, 2025 07:54
@meronogbai
Copy link
Contributor Author

No worries!

@olimorris olimorris merged commit 78b260c into olimorris:main Apr 7, 2025
@olimorris
Copy link
Owner

Once again, thank you! Amazing feature and a huge benefit to so many users

@meronogbai meronogbai deleted the feat/handle-default-providers-better branch April 7, 2025 17:24
cleong14 pushed a commit to cleong14/codecompanion.nvim that referenced this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants