Skip to content

Fix(diff): properly clear auto commands for inline integration to prevent trigger the banner.#2709

Merged
olimorris merged 1 commit intoolimorris:developfrom
bassamsdata:fix_banner
Feb 1, 2026
Merged

Fix(diff): properly clear auto commands for inline integration to prevent trigger the banner.#2709
olimorris merged 1 commit intoolimorris:developfrom
bassamsdata:fix_banner

Conversation

@bassamsdata
Copy link
Contributor

Description

Problem: The banner virtual text is triggered when switching buffers after accepting/rejecting the change.

Cause: Autocommands used for inline interaction are not properly cleared, which causes the banner to reappear in the code buffer.

Fix: This PR ensures the relevant autocommands are correctly cleared, preventing the banner from being retriggered.

AI Usage

weirdly enough, none.

Related Issue(s)

#2692 (comment)

Screenshots

the issue:

Screen.Recording.2026-01-29.at.6.10.22.PM.mp4

Checklist

  • I've read the contributing guidelines and have adhered to them in this PR
  • I confirm that this PR has been majority created by me, and not AI (unless stated in the "AI Usage" section above)
  • I've run make all to ensure docs are generated, tests pass and StyLua has formatted the code
  • (optional) I've added test coverage for this fix/feature
  • (optional) I've updated the README and/or relevant docs pages

@bassamsdata bassamsdata mentioned this pull request Feb 1, 2026
5 tasks
@olimorris
Copy link
Owner

weirdly enough, none.

Hehe this made me chuckle!

Thanks for your debugging and PR, as always 👍🏼.

@olimorris olimorris merged commit f929110 into olimorris:develop Feb 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants