Fix(diff): properly clear auto commands for inline integration to prevent trigger the banner.#2709
Merged
olimorris merged 1 commit intoolimorris:developfrom Feb 1, 2026
Merged
Conversation
Owner
Hehe this made me chuckle! Thanks for your debugging and PR, as always 👍🏼. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem: The banner virtual text is triggered when switching buffers after accepting/rejecting the change.
Cause: Autocommands used for
inline interactionare not properly cleared, which causes the banner to reappear in the code buffer.Fix: This PR ensures the relevant autocommands are correctly cleared, preventing the banner from being retriggered.
AI Usage
weirdly enough, none.
Related Issue(s)
#2692 (comment)
Screenshots
the issue:
Screen.Recording.2026-01-29.at.6.10.22.PM.mp4
Checklist
make allto ensure docs are generated, tests pass and StyLua has formatted the code