Skip to content

fix(inline): ensure placement is in lower case #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olimorris merged 1 commit into from
Feb 18, 2025
Merged

fix(inline): ensure placement is in lower case #949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lua/codecompanion/strategies/inline/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,12 +434,12 @@ function Inline:done(output)
log:error("[%s] %s", adapter_name, xml.error)
return self:reset()
end
if xml and not xml.code and xml.placement ~= "chat" then
if xml and not xml.code and string.lower(xml.placement) ~= "chat" then
log:error("[%s] Returned no code", adapter_name)
return self:reset()
end

local placement = xml and xml.placement or self.classification.placement
local placement = xml and string.lower(xml.placement) or string.lower(self.classification.placement)
log:debug("[Inline] Placement: %s", placement)
if not placement then
log:error("[%s] No placement returned", adapter_name)
Expand Down