fix(adapter): variable substitution in 'raw'. #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Awesome, thank you for this. Do you think you could add a singular test case to the adapter test file too? I'm keen to make sure any features that people add, we support with tests so I don't accidentally break them in the future. |
pettni
force-pushed
the
main
branch
2 times, most recently
from
1fde20c to
3958312
Compare
Pass adapter.raw through adapter:set_env_vars() to enable variable substitution. Also appends adapter.raw to the static raw arguments defined in the http client.
Contributor
Author
|
Sure, always a good idea to have some test. I added one in the http test file that tests that variable substitutions have been done in the data that is going to |
Owner
|
Fantastic. Thanks for such a great PR and would love to see your AWS Bedrock implementation too. |
This was referenced Feb 22, 2025
cleong14
pushed a commit
to cleong14/codecompanion.nvim
that referenced
this pull request
May 21, 2025
Pass adapter.raw through adapter:set_env_vars() to enable variable substitution. Also appends adapter.raw to the static raw arguments defined in the http client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass adapter.raw through adapter:set_env_vars() to enable variable substitution.
Also appends adapter.raw to the static raw arguments defined in the http client.
Description
Implements the change discussed in #974 that makes it easier to write an adapter for AWS Bedrock Anthropic models.
Testing
Tested with my custom Bedrock adapter, as well as a built-in adapter (deepseek).