Simplify sticky toolbar styling#122
Merged
oliver-sanders merged 1 commit intooliver-sanders:view-toolbar++from Dec 11, 2025
Merged
Simplify sticky toolbar styling#122oliver-sanders merged 1 commit intooliver-sanders:view-toolbar++from
oliver-sanders merged 1 commit intooliver-sanders:view-toolbar++from
Conversation
8 tasks
Comment on lines
-359
to
-368
| height: 4em; | ||
| padding: 0.5em; | ||
| background: white; | ||
| z-index: 1; | ||
| } | ||
| .tree { | ||
| height: calc(100% - 4.1em); | ||
| width: 100%; | ||
| padding-left: 0.5em !important; | ||
| overflow-y: scroll; |
Owner
There was a problem hiding this comment.
It's dangerous to assume that things aren't there for a reason, this diff breaks the sticky header!
You demonstrate, you'll need a workflow where the tree view is ~3x as high as the viewport. By the time you have scrolled to the bottom, the header will no longer be sticky.
Comment on lines
-19
to
-22
| <v-container | ||
| fluid | ||
| class="pa-0" | ||
| > |
Owner
There was a problem hiding this comment.
From testing, this change messes up the GScan tree.
oliver-sanders
force-pushed
the
view-toolbar++
branch
2 times, most recently
from
90841e3 to
fc38f0c
Compare
MetRonnie
force-pushed
the
sticky-toolbar
branch
from
50d8163 to
ce2d28d
Compare
oliver-sanders
approved these changes
Dec 11, 2025
oliver-sanders
merged commit 239550e
into
oliver-sanders:view-toolbar++
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.