Updated VectorBender Coding Style#32
Open
busterbeam wants to merge 1 commit intoolivierdalang:masterfrom
Open
Conversation
Mainly focused on code styling, using black style guide. Changed from old format `%` specifiers to new f-literal strings. Removed `u` prefixing on strings as all strings are Unicode in python unless otherwise specified. Any further changes where purely cosmetic no conditional logic, variable, method or class names were changed. Mild readability improvements
Owner
|
Thanks for that, it looks good. Could you also add a pre-commit setup to automatize black formatting (see https://pre-commit.com/), and add a line in the readme to explain required steps before contributing ( About line 46 no cls is just a regular variable (with indeed a confusing name). It does not by itself cause any issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per your request this Push Request has been been completely rewritten so as to focus as closely as possible to just code styling. I preformed a pass with black before and after editing the scripts. If this looks good I'm itching to make the logic flow better, also line 46 of
vectorblenderhelp.pyseems to have an error, changing fromselftoclsobject instance keywords, wondering if this might be the reason for crashes?Mainly focused on code styling, using black style guide. Changed from old format
%specifiers to new f-literal strings. Removeduprefixing on strings as all strings are Unicode in python unless otherwise specified. Any further changes where purely cosmetic no conditional logic, variable, method or class names were changed. Mild readability improvements