fix: explicitly add key in Children.map#660
Open
meowtec wants to merge 2 commits intooliviertassinari:masterfrom
Open
fix: explicitly add key in Children.map#660meowtec wants to merge 2 commits intooliviertassinari:masterfrom
Children.map#660meowtec wants to merge 2 commits intooliviertassinari:masterfrom
Conversation
…y key (and React does it).
meowtec
force-pushed
the
fix/map-children-key
branch
from
69c123b to
03e4eed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preact'sChildren.mapbehaves differently from what react does:React will clone the key from original child to mapped child, but preact will not.
I use
react-swipeable-viewswith preact (aliasreacttopreact), and that will cause some problem.So it would be better to clone the key explicitly.