Open
Conversation
- calculate sha256 - check existance
- upload blob - create blob file map - replace model file with bolb reference
- multi step approach instead of one big approach - upload blob first - validate files w hashing - send request to create model from given data - mulitple file upload supported
Author
|
@BruceMacD care to take look into this one please? |
- positive negative testing
- positive negative testing
Author
🎯 Stress Testing Results
Key Findings:
Parallel Upload Testing:
Combined Stress Test (400 operations):
💾 Memory Analysis
⚡ Performance Comparison: ollama-js vs curl
Command Needed
|
BruceMacD
reviewed
Feb 12, 2026
Member
BruceMacD
left a comment
There was a problem hiding this comment.
Thanks for all your hard work submitting this, I appreciate it.
The file upload flow gets the big picture right, blob upload via streaming, then a JSON create request with digest references. Nice work on that. A few things to address.
Author
|
All issues have been addressed. Care to take another look please? @BruceMacD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #191, #194
there will be some issues with ollama API compatibility as mentioned in https://github.com/maifeeulasad/ollama-js/blob/0bff23ca558835a47c9191f603725b2227d0f309/src/index.ts#L62 , we need to discuss further on this one
i will be writing