fix: Credentials type should be google.auth.credentials.Credentials #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed _credentials, fcm_end_point to cached propety, for better type hint - added non project_id unittest for BaseAPI
Niccari
force-pushed
the
fix/credentails_type
branch
from
a3116d0 to
aaaf7f7
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #367
The type of credentials assigned during initialization has been changed to "google.auth.credentials.Credentials".
The credentials that users assign to BaseAPI come in a variety of types, including Application Default Credentials and Impersonated Credentials.
These credentials inherit from google.auth.credentials.Credentials.
Checks