Memoizer: Persist caching to sub readers#3618
Draft
dgault wants to merge 2 commits intoome:developfrom
Draft
Conversation
Member
|
First off, wow. I find this very exciting. I only ever approached propagating to the most necessary readers in the IDR context. I do wonder if we're doing this across the board now if there are any other wrapping concerns we should consider. I imagine that might work by letting the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial PR for testing and discussion of a possible option for passing Memoization to sub readers. In this case each reader must wrap its sub readers, which leaves a significant amount of testing required to cover the large number of readers involved.
Likely to be further commits to bring this more inline with the IDR branch
New MetaxpressTiffReader also needs to be updated